Bug 2259044 - Review Request: rust-buf-min - Minimal utf-8 safe buffer traits
Summary: Review Request: rust-buf-min - Minimal utf-8 safe buffer traits
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/buf-min
Whiteboard:
Depends On:
Blocks: 2259045
TreeView+ depends on / blocked
 
Reported: 2024-01-18 19:53 UTC by Michel Lind
Modified: 2024-01-29 07:52 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-01-20 03:58:54 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 6916124 to 6916129 (1011 bytes, patch)
2024-01-18 20:13 UTC, Fedora Review Service
no flags Details | Diff

Description Michel Lind 2024-01-18 19:53:35 UTC
Spec URL: https://salimma.fedorapeople.org/specs/rust-buf-min.spec
SRPM URL: https://salimma.fedorapeople.org/specs/rust-buf-min-0.7.1-1.fc38.src.rpm

Description:
Minimal utf-8 safe buffer traits.

Fedora Account System Username: salimma

Comment 1 Michel Lind 2024-01-18 19:54:14 UTC
note: re-review of #1881231 since the package was retired

Comment 2 Fedora Review Service 2024-01-18 19:58:25 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6916124
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2259044-rust-buf-min/fedora-rawhide-x86_64/06916124-rust-buf-min/fedora-review/review.txt

Found issues:

- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/rust-buf-min
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Michel Lind 2024-01-18 20:07:54 UTC
updated to drop ntex-bytes support

[fedora-review-service-build]

Comment 4 Fedora Review Service 2024-01-18 20:13:07 UTC
Created attachment 2009167 [details]
The .spec file difference from Copr build 6916124 to 6916129

Comment 5 Fedora Review Service 2024-01-18 20:13:10 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6916129
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2259044-rust-buf-min/fedora-rawhide-x86_64/06916129-rust-buf-min/fedora-review/review.txt

Found issues:

- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/rust-buf-min
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 Fabio Valentini 2024-01-18 23:10:49 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

(only do these if they haven't already been done when this package was first imported)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 7 Michel Lind 2024-01-19 03:43:22 UTC
Thanks! Unretirement request: https://pagure.io/releng/issue/11899

Comment 8 Fedora Update System 2024-01-20 03:57:49 UTC
FEDORA-2024-52bd841df8 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-52bd841df8

Comment 9 Fedora Update System 2024-01-20 03:58:19 UTC
FEDORA-2024-7a5b8db3ba has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-7a5b8db3ba

Comment 10 Fedora Update System 2024-01-21 04:16:17 UTC
FEDORA-2024-7a5b8db3ba has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-7a5b8db3ba \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-7a5b8db3ba

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2024-01-21 04:54:17 UTC
FEDORA-2024-52bd841df8 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-52bd841df8 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-52bd841df8

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2024-01-29 06:24:02 UTC
FEDORA-2024-7a5b8db3ba has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2024-01-29 07:52:48 UTC
FEDORA-2024-52bd841df8 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.