Bug 2259238

Summary: Review Request: python-snakemake-storage-plugin-azure - Snakemake storage plugin for Azure Blob Storage
Product: [Fedora] Fedora Reporter: Ben Beasley <code>
Component: Package ReviewAssignee: Tom Rix <trix>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: package-review, trix
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---Flags: trix: fedora-review+
Hardware: All   
OS: Linux   
URL: https://github.com/snakemake/snakemake-storage-plugin-azure
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-01-24 14:03:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1276941    

Description Ben Beasley 2024-01-19 17:02:27 UTC 
Spec URL: https://music.fedorapeople.org/python-snakemake-storage-plugin-azure.spec
SRPM URL: https://music.fedorapeople.org/python-snakemake-storage-plugin-azure-0.1.4-1.fc39.src.rpm

Description:

A Snakemake storage plugin to read and write from Azure Blob Storage.

Fedora Account System Username: music

Koji scratch build (explicitly for all architectures):

F40: https://koji.fedoraproject.org/koji/taskinfo?taskID=111984867

I used a downstream-only patch to loosen the lower bounds on all of the Aazure SDK dependencies. It would be better to get these updated in Fedora (and I’m sure that will happen at some point). I’m not able to run any tests to validate this change (even with --enable-network), but I suspect it will be OK since this package uses only a small part of the respective APIs, and it looks like upstream just required the latest releases at the time the plugin was being developed, rather than basing the version bounds on specific compatibility concerns.

This will be a neuro-sig package; see https://pagure.io/neuro-sig/NeuroFedora/issue/569.
Comment 1 Fedora Review Service 2024-01-19 17:09:59 UTC 
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6922346
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2259238-python-snakemake-storage-plugin-azure/fedora-rawhide-x86_64/06922346-python-snakemake-storage-plugin-azure/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
Comment 2 Tom Rix 2024-01-20 17:45:07 UTC 
This looks fine.
Yes, testing even locally sucks.
Approved

If you have time and interest, could you review ?
https://bugzilla.redhat.com/show_bug.cgi?id=2259226
Comment 3 Fedora Admin user for bugzilla script actions 2024-01-24 01:27:03 UTC 
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-snakemake-storage-plugin-azure
Comment 4 Ben Beasley 2024-01-24 01:37:18 UTC 
Thank you for the review!

Added to release monitoring: https://release-monitoring.org/project/370959/
Comment 5 Fedora Update System 2024-01-24 14:00:47 UTC 
FEDORA-2024-710abf669a has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-710abf669a
Comment 6 Fedora Update System 2024-01-24 14:03:13 UTC 
FEDORA-2024-710abf669a has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.