Bug 2259273

Summary:	Review Request: python-snakemake-executor-plugin-cluster-sync - A Snakemake executor plugin for generic cluster jobs that are executed synchronously
Product:	[Fedora] Fedora	Reporter:	Ben Beasley <code>
Component:	Package Review	Assignee:	Steve Cossette <farchord>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	farchord, package-review
Target Milestone:	---	Keywords:	AutomationTriaged
Target Release:	---	Flags:	farchord: fedora-review+
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-01-24 13:24:14 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1276941

Description Ben Beasley 2024-01-19 21:33:57 UTC

Spec URL: https://music.fedorapeople.org/python-snakemake-executor-plugin-cluster-sync.spec
SRPM URL: https://music.fedorapeople.org/python-snakemake-executor-plugin-cluster-0.1.3-1.fc39.src.rpm

Description:

A Snakemake executor plugin for generic cluster jobs that are executed synchronously.

Fedora Account System Username: music

Koji scratch build (explicitly for all architectures):

F40: https://koji.fedoraproject.org/koji/taskinfo?taskID=112003614

Comment 1 Ben Beasley 2024-01-19 22:29:54 UTC

The %if %{without bootstrap} / %endif was copy-pasted from another spec file and is useless but harmless. I plan to remove it on import.

Comment 2 Ben Beasley 2024-01-20 00:24:24 UTC

URL typo fix:

Spec URL: https://music.fedorapeople.org/python-snakemake-executor-plugin-cluster-sync.spec
SRPM URL: https://music.fedorapeople.org/python-snakemake-executor-plugin-cluster-sync-0.1.3-1.fc39.src.rpm

Comment 3 Fedora Review Service 2024-01-20 00:28:24 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6923602
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2259273-python-snakemake-executor-plugin-cluster-sync/fedora-rawhide-x86_64/06923602-python-snakemake-executor-plugin-cluster-sync/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Steve Cossette 2024-01-22 21:26:19 UTC

* Package abides by Fedora's packaging guidelines
* Package builds, and installs properly in rawhide
* rpmlint has no serious issues
* License is free, and is allowed by Fedora.

PACKAGE APPROVED

Comment 5 Ben Beasley 2024-01-22 21:34:09 UTC

Thank you for the review!

Added to release monitoring: https://release-monitoring.org/project/371044/

I’ll request the dist-git repo after the FAS outage is resolved.

Comment 6 Fedora Admin user for bugzilla script actions 2024-01-24 01:26:02 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/python-snakemake-executor-plugin-cluster-sync

Comment 7 Fedora Update System 2024-01-24 13:20:02 UTC

FEDORA-2024-9ad6a6140b has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-9ad6a6140b

Comment 8 Fedora Update System 2024-01-24 13:24:14 UTC

FEDORA-2024-9ad6a6140b has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.