Bug 2259330
| Summary: | Review Request: rust-crypto_secretbox - Pure Rust implementation of the XSalsa20Poly1305 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mikel Olasagasti Uranga <mikel> | ||||
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> | ||||
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | decathorpe, fedora, package-review | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | https://crates.io/crates/crypto_secretbox | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2024-08-05 00:45:33 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 2259019 | ||||||
| Bug Blocks: | 201449, 2297310 | ||||||
| Attachments: |
|
||||||
|
Description
Mikel Olasagasti Uranga
2024-01-20 12:11:44 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/6926739 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2259330-rust-crypto_secretbox/fedora-rawhide-x86_64/06926739-rust-crypto_secretbox/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Looks like the heuristics for getting a good Summary from the crate description failed here - can you update it please? Maybe something like "Implementation of the XSalsa20Poly1305 and XChaCha20Poly1305 ciphers". Spec URL: https://mikel.olasagasti.info/tmp/fedora/rust-crypto_secretbox.spec SRPM URL: https://mikel.olasagasti.info/tmp/fedora/rust-crypto_secretbox-0.1.1-1.fc39.src.rpm Changed summary with your proposal Created attachment 2010570 [details]
The .spec file difference from Copr build 6926739 to 6952766
Copr build: https://copr.fedorainfracloud.org/coprs/build/6952766 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2259330-rust-crypto_secretbox/fedora-rawhide-x86_64/06952766-rust-crypto_secretbox/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Thanks! Package looks good in general, but there's a missing optional dependency: Failed to resolve the transaction: Problem: conflicting requests - nothing provides (crate(chacha20/default) >= 0.9.0 with crate(chacha20/default) < 0.10.0~) needed by rust-crypto_secretbox+chacha20-devel-0.1.1-1.fc40.noarch - nothing provides (crate(chacha20/zeroize) >= 0.9.0 with crate(chacha20/zeroize) < 0.10.0~) needed by rust-crypto_secretbox+chacha20-devel-0.1.1-1.fc40.noarch You will need to either disable the chacha20 support, or package the missing crate (chacha20 version 0.9.*). Sorry Fabio, where did you see that one? Package is building fine in Rawhide. For F39 & F38 fails because "crate(poly1305/default)" is missing as I've not backported it yet, I'm focusing in rawhide for now. This is not about *building* correctly but about *installing* correctly. You can reproduce by running a local mock build with "--postinstall" or by attempting to install the results of a build in a rawhide mock chroot. This happens for dependencies for features that are not enabled by default, which is fairly common in Rust crates. Which is why I always recommend to run test builds with "--postinstall". Are you still interested in packaging this crate? The chacha20 crate has been packaged in the meantime. This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it. *** This bug has been marked as a duplicate of bug 2318533 *** |