Bug 225955
| Summary: | Merge Review: jwhois | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nobody's working on this, feel free to take it <nobody> |
| Component: | Package Review | Assignee: | Lubomir Rintel <lkundrak> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mitr, vcrhonek |
| Target Milestone: | --- | Flags: | lkundrak:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-12-07 08:23:18 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Nobody's working on this, feel free to take it
2007-01-31 19:14:12 UTC
You don't use _smp_mflags at all You don't need to [ "$RPM_BUILD_ROOT" != "/" ] before rm -fr $RPM_BUILD_ROOT RPMlint: jwhois.src:11: W: unversioned-explicit-obsoletes fwhois jwhois.src:11: W: unversioned-explicit-obsoletes whois Just fine if jwhois is incompatible. Is it? jwhois.src:65: W: macro-in-%changelog lang use double %. Ping on this. (In reply to comment #1) > You don't use _smp_mflags at all I found no bug against _smp_flags in history and it works, so I will add it. > You don't need to [ "$RPM_BUILD_ROOT" != "/" ] before rm -fr $RPM_BUILD_ROOT I will remove it. > RPMlint: > > jwhois.src:11: W: unversioned-explicit-obsoletes fwhois > jwhois.src:11: W: unversioned-explicit-obsoletes whois > > Just fine if jwhois is incompatible. Is it? I think so, but I'm not sure. AFAIK fwhois and whois are not used in Fedora, fwhois is dead...? Mirek, do you know more about it? > jwhois.src:65: W: macro-in-%changelog lang > > use double %. I will fix it. IIRC both jwhois and fwhois were obsoleted by jwhois at least since RHL 6. I don't think removing the Obsoletes: would be a problem. Please replace
Buildroot: %{_tmppath}/%{name}-%{version}-root
with
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
Ping on this. I see you fixed the buildroot in CVS. Now package looks almost perfect. -- I noticed one more thing: I believe that autoconf and automake dependencies are unnecessary, you don't rebuild autotools files. You're right, fixed in CVS. The package seems fine now. Thanks. Package Change Request ====================== Package Name: jwhois New Branches: epel7 Owners: vcrhonek The package is not available in RHEL7. https://bugzilla.redhat.com/show_bug.cgi?id=1145288 Git done (by process-git-requests). In the future use your FAS account name, not your email address. |