Bug 225955 - Merge Review: jwhois
Merge Review: jwhois
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Lubomir Rintel
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 14:14 EST by Nobody's working on this, feel free to take it
Modified: 2014-09-24 07:17 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-12-07 03:23:18 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
lkundrak: fedora‑review+
limburgher: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 14:14:12 EST
Fedora Merge Review: jwhois

http://cvs.fedora.redhat.com/viewcvs/devel/jwhois/
Initial Owner: mitr@redhat.com
Comment 1 Lubomir Kundrak 2007-11-20 11:16:31 EST
You don't use _smp_mflags at all
You don't need to [ "$RPM_BUILD_ROOT" != "/" ] before rm -fr $RPM_BUILD_ROOT

RPMlint:

jwhois.src:11: W: unversioned-explicit-obsoletes fwhois
jwhois.src:11: W: unversioned-explicit-obsoletes whois

Just fine if jwhois is incompatible. Is it?

jwhois.src:65: W: macro-in-%changelog lang

use double %.
Comment 2 Lubomir Kundrak 2007-11-27 07:32:22 EST
Ping on this.
Comment 3 Vitezslav Crhonek 2007-11-27 08:28:55 EST
(In reply to comment #1)
> You don't use _smp_mflags at all

I found no bug against _smp_flags in history and it works, so I will add it.

> You don't need to [ "$RPM_BUILD_ROOT" != "/" ] before rm -fr $RPM_BUILD_ROOT

I will remove it.

> RPMlint:
> 
> jwhois.src:11: W: unversioned-explicit-obsoletes fwhois
> jwhois.src:11: W: unversioned-explicit-obsoletes whois
> 
> Just fine if jwhois is incompatible. Is it?

I think so, but I'm not sure. AFAIK fwhois and whois are not used in Fedora,
fwhois is dead...? Mirek, do you know more about it?

> jwhois.src:65: W: macro-in-%changelog lang
> 
> use double %.

I will fix it.
Comment 4 Miloslav Trmač 2007-11-27 08:35:38 EST
IIRC both jwhois and fwhois were obsoleted by jwhois at least since RHL 6.  I
don't think removing the Obsoletes: would be a problem.
Comment 5 Lubomir Kundrak 2007-11-28 10:15:15 EST
Please replace

Buildroot: %{_tmppath}/%{name}-%{version}-root

with

BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
Comment 6 Lubomir Kundrak 2007-12-04 09:46:24 EST
Ping on this.
Comment 7 Lubomir Kundrak 2007-12-06 08:52:31 EST
I see you fixed the buildroot in CVS. Now package looks almost perfect. -- I
noticed one more thing: I believe that autoconf and automake dependencies are
unnecessary, you don't rebuild autotools files.
Comment 8 Vitezslav Crhonek 2007-12-06 09:57:05 EST
You're right, fixed in CVS.
Comment 9 Lubomir Kundrak 2007-12-07 03:19:46 EST
The package seems fine now. Thanks.
Comment 10 Vitezslav Crhonek 2014-09-24 06:30:08 EDT
Package Change Request
======================
Package Name: jwhois
New Branches: epel7
Owners: vcrhonek@redhat.com

The package is not available in RHEL7.
https://bugzilla.redhat.com/show_bug.cgi?id=1145288
Comment 11 Jon Ciesla 2014-09-24 07:17:15 EDT
Git done (by process-git-requests).

In the future use your FAS account name, not your email address.

Note You need to log in before you can comment on or make changes to this bug.