Fedora Merge Review: jwhois http://cvs.fedora.redhat.com/viewcvs/devel/jwhois/ Initial Owner: mitr
You don't use _smp_mflags at all You don't need to [ "$RPM_BUILD_ROOT" != "/" ] before rm -fr $RPM_BUILD_ROOT RPMlint: jwhois.src:11: W: unversioned-explicit-obsoletes fwhois jwhois.src:11: W: unversioned-explicit-obsoletes whois Just fine if jwhois is incompatible. Is it? jwhois.src:65: W: macro-in-%changelog lang use double %.
Ping on this.
(In reply to comment #1) > You don't use _smp_mflags at all I found no bug against _smp_flags in history and it works, so I will add it. > You don't need to [ "$RPM_BUILD_ROOT" != "/" ] before rm -fr $RPM_BUILD_ROOT I will remove it. > RPMlint: > > jwhois.src:11: W: unversioned-explicit-obsoletes fwhois > jwhois.src:11: W: unversioned-explicit-obsoletes whois > > Just fine if jwhois is incompatible. Is it? I think so, but I'm not sure. AFAIK fwhois and whois are not used in Fedora, fwhois is dead...? Mirek, do you know more about it? > jwhois.src:65: W: macro-in-%changelog lang > > use double %. I will fix it.
IIRC both jwhois and fwhois were obsoleted by jwhois at least since RHL 6. I don't think removing the Obsoletes: would be a problem.
Please replace Buildroot: %{_tmppath}/%{name}-%{version}-root with BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
I see you fixed the buildroot in CVS. Now package looks almost perfect. -- I noticed one more thing: I believe that autoconf and automake dependencies are unnecessary, you don't rebuild autotools files.
You're right, fixed in CVS.
The package seems fine now. Thanks.
Package Change Request ====================== Package Name: jwhois New Branches: epel7 Owners: vcrhonek The package is not available in RHEL7. https://bugzilla.redhat.com/show_bug.cgi?id=1145288
Git done (by process-git-requests). In the future use your FAS account name, not your email address.