Bug 2259838
| Summary: | Review Request: checkpointctl - a tool for analysis of container checkpoints | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Radostin Stoyanov <rstoyano> | ||||||
| Component: | Package Review | Assignee: | Adrian Reber <adrian> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | adrian, package-review | ||||||
| Target Milestone: | --- | Flags: | adrian:
fedora-review+
|
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| URL: | %{git0} | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2024-01-29 11:49:12 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Radostin Stoyanov
2024-01-23 09:49:18 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/6942756 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2259838-checkpointctl/fedora-rawhide-x86_64/06942756-checkpointctl/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://raw.githubusercontent.com/rst0git/checkpointctl-rpm/main/checkpointctl.spec SRPM URL: https://github.com/rst0git/checkpointctl-rpm/raw/main/checkpointctl-1.1.0-3.fc40.src.rpm Description: A command-line tool for in-depth analysis of container checkpoints Fedora Account System Username: rstoyanov Created attachment 2010060 [details]
The .spec file difference from Copr build 6942756 to 6945515
Copr build: https://copr.fedorainfracloud.org/coprs/build/6945515 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2259838-checkpointctl/fedora-rawhide-x86_64/06945515-checkpointctl/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. The review tool complains about "[!]: Uses parallel make %{?_smp_mflags} macro.". It does not make much sense for a Go package but you could still add "%{?_smp_mflags}" after make.
You could also add a "%check" section and run the test suite.
I am not sure about the `with_debug` logic. Is that needed?
You should also install the auto-completion files. Spec URL: https://raw.githubusercontent.com/rst0git/checkpointctl-rpm/main/checkpointctl.spec SRPM URL: https://github.com/rst0git/checkpointctl-rpm/raw/main/checkpointctl-1.1.0-5.fc40.src.rpm Description: A command-line tool for in-depth analysis of container checkpoints Fedora Account System Username: rstoyanov Created attachment 2010744 [details]
The .spec file difference from Copr build 6945515 to 6964190
Copr build: https://copr.fedorainfracloud.org/coprs/build/6964190 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2259838-checkpointctl/fedora-rawhide-x86_64/06964190-checkpointctl/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. The Pagure repository was created at https://src.fedoraproject.org/rpms/checkpointctl FEDORA-2024-0d67ae4669 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-0d67ae4669 FEDORA-2024-0d67ae4669 has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-4f3d8b7775 (checkpointctl-1.1.0-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-4f3d8b7775 FEDORA-2024-cff378ace4 (checkpointctl-1.1.0-1.fc38) has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-cff378ace4 FEDORA-EPEL-2024-8e51f8ba56 (checkpointctl-1.1.0-1.el9) has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-8e51f8ba56 FEDORA-2024-4f3d8b7775 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-4f3d8b7775 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-4f3d8b7775 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2024-8e51f8ba56 has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-8e51f8ba56 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-cff378ace4 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-cff378ace4 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-cff378ace4 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2024-8e51f8ba56 (checkpointctl-1.1.0-1.el9) has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-4f3d8b7775 (checkpointctl-1.1.0-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-cff378ace4 (checkpointctl-1.1.0-1.fc38) has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2025-5c1d116fa3 (checkpointctl-1.4.0-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2025-5c1d116fa3 FEDORA-2025-5c1d116fa3 (checkpointctl-1.4.0-1.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report. |