Bug 2259838 - Review Request: checkpointctl - a tool for analysis of container checkpoints
Summary: Review Request: checkpointctl - a tool for analysis of container checkpoints
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Adrian Reber
QA Contact: Fedora Extras Quality Assurance
URL: %{git0}
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-01-23 09:49 UTC by Radostin Stoyanov
Modified: 2024-02-17 01:37 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-01-29 11:49:12 UTC
Type: ---
Embargoed:
adrian: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 6942756 to 6945515 (1.54 KB, patch)
2024-01-24 09:01 UTC, Fedora Review Service
no flags Details | Diff
The .spec file difference from Copr build 6945515 to 6964190 (1.58 KB, patch)
2024-01-26 15:10 UTC, Fedora Review Service
no flags Details | Diff

Description Radostin Stoyanov 2024-01-23 09:49:18 UTC
Spec URL: https://raw.githubusercontent.com/rst0git/checkpointctl-rpm/main/checkpointctl.spec
SRPM URL: https://github.com/rst0git/checkpointctl-rpm/raw/main/checkpointctl-1.1.0-3.fc40.src.rpm
Description: A command-line tool for in-depth analysis of container checkpoints
Fedora Account System Username: rstoyanov

Comment 1 Fedora Review Service 2024-01-23 09:52:28 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6942756
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2259838-checkpointctl/fedora-rawhide-x86_64/06942756-checkpointctl/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Radostin Stoyanov 2024-01-24 08:53:40 UTC
Spec URL: https://raw.githubusercontent.com/rst0git/checkpointctl-rpm/main/checkpointctl.spec
SRPM URL: https://github.com/rst0git/checkpointctl-rpm/raw/main/checkpointctl-1.1.0-3.fc40.src.rpm
Description: A command-line tool for in-depth analysis of container checkpoints
Fedora Account System Username: rstoyanov

Comment 3 Fedora Review Service 2024-01-24 09:01:01 UTC
Created attachment 2010060 [details]
The .spec file difference from Copr build 6942756 to 6945515

Comment 4 Fedora Review Service 2024-01-24 09:01:03 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6945515
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2259838-checkpointctl/fedora-rawhide-x86_64/06945515-checkpointctl/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Adrian Reber 2024-01-25 07:51:46 UTC
The review tool complains about "[!]: Uses parallel make %{?_smp_mflags} macro.". It does not make much sense for a Go package but you could still add "%{?_smp_mflags}" after make.

You could also add a "%check" section and run the test suite.

I am not sure about the `with_debug` logic. Is that needed?

Comment 6 Adrian Reber 2024-01-25 13:44:43 UTC
You should also install the auto-completion files.

Comment 7 Radostin Stoyanov 2024-01-26 15:01:28 UTC
Spec URL: https://raw.githubusercontent.com/rst0git/checkpointctl-rpm/main/checkpointctl.spec
SRPM URL: https://github.com/rst0git/checkpointctl-rpm/raw/main/checkpointctl-1.1.0-5.fc40.src.rpm
Description: A command-line tool for in-depth analysis of container checkpoints
Fedora Account System Username: rstoyanov

Comment 8 Fedora Review Service 2024-01-26 15:10:20 UTC
Created attachment 2010744 [details]
The .spec file difference from Copr build 6945515 to 6964190

Comment 9 Fedora Review Service 2024-01-26 15:10:23 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6964190
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2259838-checkpointctl/fedora-rawhide-x86_64/06964190-checkpointctl/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 10 Fedora Admin user for bugzilla script actions 2024-01-29 10:09:58 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/checkpointctl

Comment 11 Fedora Update System 2024-01-29 11:48:47 UTC
FEDORA-2024-0d67ae4669 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-0d67ae4669

Comment 12 Fedora Update System 2024-01-29 11:49:12 UTC
FEDORA-2024-0d67ae4669 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2024-02-08 10:30:26 UTC
FEDORA-2024-4f3d8b7775 (checkpointctl-1.1.0-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-4f3d8b7775

Comment 14 Fedora Update System 2024-02-08 10:31:22 UTC
FEDORA-2024-cff378ace4 (checkpointctl-1.1.0-1.fc38) has been submitted as an update to Fedora 38.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-cff378ace4

Comment 15 Fedora Update System 2024-02-08 10:33:32 UTC
FEDORA-EPEL-2024-8e51f8ba56 (checkpointctl-1.1.0-1.el9) has been submitted as an update to Fedora EPEL 9.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-8e51f8ba56

Comment 16 Fedora Update System 2024-02-09 01:39:53 UTC
FEDORA-2024-4f3d8b7775 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-4f3d8b7775 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-4f3d8b7775

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 17 Fedora Update System 2024-02-09 01:50:34 UTC
FEDORA-EPEL-2024-8e51f8ba56 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-8e51f8ba56

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 18 Fedora Update System 2024-02-09 02:17:28 UTC
FEDORA-2024-cff378ace4 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-cff378ace4 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-cff378ace4

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 19 Fedora Update System 2024-02-17 00:56:42 UTC
FEDORA-EPEL-2024-8e51f8ba56 (checkpointctl-1.1.0-1.el9) has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 20 Fedora Update System 2024-02-17 00:57:16 UTC
FEDORA-2024-4f3d8b7775 (checkpointctl-1.1.0-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 21 Fedora Update System 2024-02-17 01:37:20 UTC
FEDORA-2024-cff378ace4 (checkpointctl-1.1.0-1.fc38) has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.