Bug 225985
Summary: | Merge Review: libaio | |||
---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Nobody's working on this, feel free to take it <nobody> | |
Component: | libaio | Assignee: | Nobody's working on this, feel free to take it <nobody> | |
Status: | CLOSED EOL | QA Contact: | Fedora Package Reviews List <fedora-package-review> | |
Severity: | medium | Docs Contact: | ||
Priority: | medium | |||
Version: | 23 | CC: | esandeen, jmoyer, mattdm, tomspur | |
Target Milestone: | --- | |||
Target Release: | --- | |||
Hardware: | All | |||
OS: | Linux | |||
Whiteboard: | ||||
Fixed In Version: | Doc Type: | Bug Fix | ||
Doc Text: | Story Points: | --- | ||
Clone Of: | ||||
: | 567783 (view as bug list) | Environment: | ||
Last Closed: | 2016-12-20 11:58:00 UTC | Type: | --- | |
Regression: | --- | Mount Type: | --- | |
Documentation: | --- | CRM: | ||
Verified Versions: | Category: | --- | ||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
Cloudforms Team: | --- | Target Upstream Version: | ||
Embargoed: |
Description
Nobody's working on this, feel free to take it
2007-01-31 19:18:20 UTC
This package is far from following the guidelines. In my opinion the first thing to do would be to find a proper hosting, this would also simplify the life of other distro maintainers. Unless I'm wrong this has already been done by other packagers, there is a hosting at fedoraproject if you like it. The source is available via anonymous CVS on rhlinux.redhat.com: cvs -d :pserver:anonymous.com:/usr/local/CVS login (no password) cvs -d :pserver:anonymous.com:/usr/local/CVS co libaio Ok, then you should use the relevant part in http://fedoraproject.org/wiki/Packaging/SourceURL So just as a drive-by partial review, for fedora at least: rpmlint -i libaio-0.3.107-9.1.fc13.src.rpm libaio.src: W: no-url-tag The URL tag is missing. It'd be great to have: URL: http://git.kernel.org/?p=libs/libaio/libaio.git in there (or whatever the appropriate starting-point for folks looking for libaio might be...) Also, for releases that have a tarball under http://kernel.org/pub/linux/libs/aio/, please change to: Source: http://kernel.org/pub/linux/libs/aio/%{name}-%{version}.tar.gz libaio.src:33: W: setup-not-quiet Use the -q option to the %setup macro to avoid useless build output from unpacking the sources. I guess it wants "-q" ;) libaio.src:233: W: macro-in-%changelog %files Macros are expanded in %changelog too, which can in unfortunate cases lead to the package not building at all, or other subtle unexpected conditions that affect the build. Even when that doesn't happen, the expansion results in possibly "rewriting history" on subsequent package revisions and generally odd entries eg. in source rpms, which is rarely wanted. Avoid use of macros in %changelog altogether, or use two '%'s to escape them, like '%%foo'. This is due to: * Sat Apr 12 2002 Benjamin LaHaise <bcrl> - add /lib/libredhat-kernel* to %files. which is trivial to fix. libaio.src: W: mixed-use-of-spaces-and-tabs (spaces: line 6, tab: line 55) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. ok that's just a nitpick. As for the built binaries: # rpmlint -i /root/rpmbuild/RPMS/x86_64/libaio-0.3.107-9.1.fc12.x86_64.rpm libaio.x86_64: W: no-url-tag The URL tag is missing. same as above libaio.x86_64: E: shared-lib-without-dependency-information /lib64/libaio.so.1.0.0 libaio.x86_64: E: shared-lib-without-dependency-information /lib64/libaio.so.1.0.1 1 packages and 0 specfiles checked; 2 errors, 1 warnings. this is because src/Makefile has -nostdlib -nostartfiles - I'm not sure what the point of that is... # rpmlint -i /root/rpmbuild/RPMS/x86_64/libaio-devel-0.3.107-9.1.fc12.x86_64.rpm libaio-devel.x86_64: W: no-version-dependency-on libaio/libaio-libs/liblibaio 0.3.107 libaio-devel.x86_64: W: no-url-tag The URL tag is missing. same as above. libaio-devel.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. *shrug* 1 packages and 0 specfiles checked; 0 errors, 3 warnings. One "Must" tidbit: MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} [23] https://fedoraproject.org/wiki/Packaging/Guidelines#RequiringBasePackage You just have: %package devel Summary: Development files for Linux-native asynchronous I/O access Group: Development/System Requires: libaio without the version & release. Ping, any progress here? Mass reassigning all merge reviews to their component. For more details, see this FESCO ticket: https://fedorahosted.org/fesco/ticket/1269 If you don't know what merge reviews are about, please see: https://fedoraproject.org/wiki/Merge_Reviews How to handle this bug is left to the discretion of the package maintainer. This bug appears to have been reported against 'rawhide' during the Fedora 23 development cycle. Changing version to '23'. (As we did not run this process for some time, it could affect also pre-Fedora 23 development cycle bugs. We are very sorry. It will help us with cleanup during Fedora 23 End Of Life. Thank you.) More information and reason for this action is here: https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora23 This message is a reminder that Fedora 23 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 23. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '23'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 23 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. Fedora 23 changed to end-of-life (EOL) status on 2016-12-20. Fedora 23 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed. |