Bug 225985 - Merge Review: libaio
Merge Review: libaio
Status: NEW
Product: Fedora
Classification: Fedora
Component: libaio (Show other bugs)
23
All Linux
medium Severity medium
: ---
: ---
Assigned To: Nobody's working on this, feel free to take it
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 14:18 EST by Nobody's working on this, feel free to take it
Modified: 2015-07-15 11:25 EDT (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 567783 (view as bug list)
Environment:
Last Closed:
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 14:18:20 EST
Fedora Merge Review: libaio

http://cvs.fedora.redhat.com/viewcvs/devel/libaio/
Initial Owner: jmoyer@redhat.com
Comment 1 Patrice Dumas 2007-11-14 16:35:29 EST
This package is far from following the guidelines. In my 
opinion the first thing to do would be to find a proper 
hosting, this would also simplify the life of other
distro maintainers. Unless I'm wrong this has already
been done by other packagers, there is a hosting at 
fedoraproject if you like it.
Comment 2 Jeffrey Moyer 2007-11-14 16:50:37 EST
The source is available via anonymous CVS on rhlinux.redhat.com:

cvs -d :pserver:anonymous@rhlinux.redhat.com:/usr/local/CVS login
(no password)
cvs -d :pserver:anonymous@rhlinux.redhat.com:/usr/local/CVS co libaio
Comment 3 Patrice Dumas 2007-11-14 17:23:41 EST
Ok, then you should use the relevant part in
http://fedoraproject.org/wiki/Packaging/SourceURL
Comment 4 Eric Sandeen 2010-01-06 12:12:47 EST
So just as a drive-by partial review, for fedora at least:

rpmlint -i libaio-0.3.107-9.1.fc13.src.rpm 
libaio.src: W: no-url-tag
The URL tag is missing.

It'd be great to have:

URL: http://git.kernel.org/?p=libs/libaio/libaio.git

in there (or whatever the appropriate starting-point for folks looking for libaio might be...)

Also, for releases that have a tarball under http://kernel.org/pub/linux/libs/aio/, please change to:

Source: http://kernel.org/pub/linux/libs/aio/%{name}-%{version}.tar.gz

libaio.src:33: W: setup-not-quiet
Use the -q option to the %setup macro to avoid useless build output from
unpacking the sources.

I guess it wants "-q" ;)

libaio.src:233: W: macro-in-%changelog %files
Macros are expanded in %changelog too, which can in unfortunate cases lead to
the package not building at all, or other subtle unexpected conditions that
affect the build.  Even when that doesn't happen, the expansion results in
possibly "rewriting history" on subsequent package revisions and generally odd
entries eg. in source rpms, which is rarely wanted.  Avoid use of macros in
%changelog altogether, or use two '%'s to escape them, like '%%foo'.

This is due to:

* Sat Apr 12 2002 Benjamin LaHaise <bcrl@redhat.com>
- add /lib/libredhat-kernel* to %files.

which is trivial to fix.

libaio.src: W: mixed-use-of-spaces-and-tabs (spaces: line 6, tab: line 55)
The specfile mixes use of spaces and tabs for indentation, which is a cosmetic
annoyance.  Use either spaces or tabs for indentation, not both.

ok that's just a nitpick.

As for the built binaries:

# rpmlint -i /root/rpmbuild/RPMS/x86_64/libaio-0.3.107-9.1.fc12.x86_64.rpm
libaio.x86_64: W: no-url-tag
The URL tag is missing.

same as above

libaio.x86_64: E: shared-lib-without-dependency-information /lib64/libaio.so.1.0.0
libaio.x86_64: E: shared-lib-without-dependency-information /lib64/libaio.so.1.0.1
1 packages and 0 specfiles checked; 2 errors, 1 warnings.

this is because src/Makefile has -nostdlib -nostartfiles - I'm not sure what the point of that is...

# rpmlint -i /root/rpmbuild/RPMS/x86_64/libaio-devel-0.3.107-9.1.fc12.x86_64.rpm
libaio-devel.x86_64: W: no-version-dependency-on libaio/libaio-libs/liblibaio 0.3.107
libaio-devel.x86_64: W: no-url-tag
The URL tag is missing.

same as above.

libaio-devel.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

*shrug*

1 packages and 0 specfiles checked; 0 errors, 3 warnings.
Comment 5 Eric Sandeen 2010-01-06 12:26:45 EST
One "Must" tidbit:

MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release}  [23]

https://fedoraproject.org/wiki/Packaging/Guidelines#RequiringBasePackage

You just have:

%package devel
Summary: Development files for Linux-native asynchronous I/O access
Group: Development/System
Requires: libaio

without the version & release.
Comment 6 Thomas Spura 2010-07-18 20:10:59 EDT
Ping, any progress here?
Comment 7 Cole Robinson 2015-02-11 15:37:27 EST
Mass reassigning all merge reviews to their component. For more details, see this FESCO ticket:

  https://fedorahosted.org/fesco/ticket/1269

If you don't know what merge reviews are about, please see:

  https://fedoraproject.org/wiki/Merge_Reviews

How to handle this bug is left to the discretion of the package maintainer.
Comment 8 Jan Kurik 2015-07-15 11:25:32 EDT
This bug appears to have been reported against 'rawhide' during the Fedora 23 development cycle.
Changing version to '23'.

(As we did not run this process for some time, it could affect also pre-Fedora 23 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 23 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora23

Note You need to log in before you can comment on or make changes to this bug.