Bug 226005

Summary: Merge Review: libFS
Product: [Fedora] Fedora Reporter: Nobody's working on this, feel free to take it <nobody>
Component: Package ReviewAssignee: Thomas Spura <tomspur>
Status: CLOSED RAWHIDE QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: ajax, sandmann, tomspur
Target Milestone: ---Flags: tomspur: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-08-30 19:55:48 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Nobody's working on this, feel free to take it 2007-01-31 19:21:31 UTC 
Fedora Merge Review: libFS

http://cvs.fedora.redhat.com/viewcvs/devel/libFS/
Initial Owner: sandmann
Comment 1 Thomas Spura 2010-07-19 15:05:46 UTC 
(CC'ing last modifiers)

Why do you use 'with_static' for deciding to build the static lib or not?

But even, when doing this, you need to package the static libs in a subpackage called 'static' and do NOT place them in the usual devel subpackage...

Either delete that completely or properly package it in a static subpackage...


Other issues:
- Please use INSTALL="install -p" when installing to preserve timestamps
- https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make
- There is a new version 1.0.2 upstream.
- libFS-devel.x86_64: E: useless-provides libFS-devel
  libFS.src:23: W: unversioned-explicit-provides %{name}-devel

The rest looks good so far.
Comment 2 Adam Jackson 2010-08-30 19:55:48 UTC 
fixed in libFS-1.0.2-1.fc15
Comment 3 Thomas Spura 2010-08-30 20:27:29 UTC 
(In reply to comment #2)
> fixed in libFS-1.0.2-1.fc15

Thanks so far.
Last thing, that _could_ be done is:
- libFS.x86_64: E: zero-length /usr/share/doc/libFS-1.0.2/AUTHORS

- parallel make is still not implemented, but unfortunately, that's only SHOULD 
  in the guidelines...

________________________________________________________________________________


APPROVED