Bug 226005 – Merge Review: libFS

Bugzilla will be upgraded to version 5.0 on a still to be determined date in the near future. The original upgrade date has been delayed.

Bug 226005 - Merge Review: libFS

Summary:	Merge Review: libFS

Status:	CLOSED RAWHIDE

Aliases:	None

Product:	Fedora
Classification:	Fedora
Component:	Package Review (Show other bugs)
Sub Component:
Version:	rawhide
Hardware:	All Linux

Priority	medium Severity medium
Target Milestone:	---
Target Release:	---
Assigned To:	Thomas Spura
QA Contact:	Fedora Package Reviews List
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2007-01-31 14:21 EST by Nobody's working on this, feel free to take it
Modified:	2010-08-30 16:27 EDT (History)
CC List:	3 users (show)

See Also:
Fixed In Version:
Doc Type:	Bug Fix
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2010-08-30 15:55:48 EDT
Type:	---
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Flags:	tomspur: fedora‑review+

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Groups: None (edit)

Description Nobody's working on this, feel free to take it 2007-01-31 14:21:31 EST

Fedora Merge Review: libFS

http://cvs.fedora.redhat.com/viewcvs/devel/libFS/
Initial Owner: sandmann@redhat.com

Comment 1 Thomas Spura 2010-07-19 11:05:46 EDT

(CC'ing last modifiers)

Why do you use 'with_static' for deciding to build the static lib or not?

But even, when doing this, you need to package the static libs in a subpackage called 'static' and do NOT place them in the usual devel subpackage...

Either delete that completely or properly package it in a static subpackage...


Other issues:
- Please use INSTALL="install -p" when installing to preserve timestamps
- https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make
- There is a new version 1.0.2 upstream.
- libFS-devel.x86_64: E: useless-provides libFS-devel
  libFS.src:23: W: unversioned-explicit-provides %{name}-devel

The rest looks good so far.

Comment 2 Adam Jackson 2010-08-30 15:55:48 EDT

fixed in libFS-1.0.2-1.fc15

Comment 3 Thomas Spura 2010-08-30 16:27:29 EDT

(In reply to comment #2)
> fixed in libFS-1.0.2-1.fc15

Thanks so far.
Last thing, that _could_ be done is:
- libFS.x86_64: E: zero-length /usr/share/doc/libFS-1.0.2/AUTHORS

- parallel make is still not implemented, but unfortunately, that's only SHOULD 
  in the guidelines...

________________________________________________________________________________


APPROVED

Note You need to log in before you can comment on or make changes to this bug.