Fedora Merge Review: libFS http://cvs.fedora.redhat.com/viewcvs/devel/libFS/ Initial Owner: sandmann
(CC'ing last modifiers) Why do you use 'with_static' for deciding to build the static lib or not? But even, when doing this, you need to package the static libs in a subpackage called 'static' and do NOT place them in the usual devel subpackage... Either delete that completely or properly package it in a static subpackage... Other issues: - Please use INSTALL="install -p" when installing to preserve timestamps - https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make - There is a new version 1.0.2 upstream. - libFS-devel.x86_64: E: useless-provides libFS-devel libFS.src:23: W: unversioned-explicit-provides %{name}-devel The rest looks good so far.
fixed in libFS-1.0.2-1.fc15
(In reply to comment #2) > fixed in libFS-1.0.2-1.fc15 Thanks so far. Last thing, that _could_ be done is: - libFS.x86_64: E: zero-length /usr/share/doc/libFS-1.0.2/AUTHORS - parallel make is still not implemented, but unfortunately, that's only SHOULD in the guidelines... ________________________________________________________________________________ APPROVED