Bug 226039
| Summary: | Merge Review: libraw1394 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nobody's working on this, feel free to take it <nobody> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jarod, pertusus, tcallawa |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | tcallawa:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-02-26 16:38:38 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Nobody's working on this, feel free to take it
2007-01-31 19:26:49 UTC
macros in %changelog: change %dist to %%dist; %files to %%files Everything else ok (source matches updstream; license ok) Not quite everything else was okay, the buildroot wasn't correct. I've fixed that and the macros in the changelog though. This package doesn't build for me. An example of an error: raw1394-iso.c: In function 'queue_packet': raw1394-iso.c:43: error: 'struct fw_cdev_iso_packet' has no member named 'payload_length' raw1394-iso.c:44: error: 'struct fw_cdev_iso_packet' has no member named 'interrupt' raw1394-iso.c:46: error: 'struct fw_cdev_iso_packet' has no member named 'skip' raw1394-iso.c:47: error: 'struct fw_cdev_iso_packet' has no member named 'tag' raw1394-iso.c:48: error: 'struct fw_cdev_iso_packet' has no member named 'sy' raw1394-iso.c:49: error: 'struct fw_cdev_iso_packet' has no member named 'header_length' The version in rawhide builds properly on F8, I just need to get around to pulling those same changes over. All set. Reopening. No one actually did a proper review here. Oops, mah bad. However, I can do a review quickly for you. :) The only issues I see are: 1. The License tag is incorrect, it should be LGPLv2+. 2. You're using a tab separator on line 11, and spaces everywhere else. Since these items are pedantic, and easily corrected in CVS, this package is approved. Please commit those changes. :) Here's the full review notes: Good: - rpmlint checks return: libraw1394.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 11) libraw1394.src: W: invalid-license LGPL libraw1394.x86_64: W: invalid-license LGPL libraw1394-devel.x86_64: W: invalid-license LGPL libraw1394-debuginfo.x86_64: W: invalid-license LGPL Needs fixing in CVS, not a blocker for review. - package meets naming guidelines - package meets packaging guidelines (except for license tag) - license (LGPLv2+) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - post/postun ldconfig ok - devel requires base package n-v-r Thanks much, committed to rawhide cvs a few minutes ago. Looks good! Closing this one out. |