Red Hat Bugzilla – Bug 226039
Merge Review: libraw1394
Last modified: 2008-02-26 11:38:38 EST
Fedora Merge Review: libraw1394
Initial Owner: email@example.com
macros in %changelog: change %dist to %%dist; %files to %%files
Everything else ok (source matches updstream; license ok)
Not quite everything else was okay, the buildroot wasn't correct. I've fixed that and the macros in the
This package doesn't build for me. An example of an error:
raw1394-iso.c: In function 'queue_packet':
raw1394-iso.c:43: error: 'struct fw_cdev_iso_packet' has no member named
raw1394-iso.c:44: error: 'struct fw_cdev_iso_packet' has no member named 'interrupt'
raw1394-iso.c:46: error: 'struct fw_cdev_iso_packet' has no member named 'skip'
raw1394-iso.c:47: error: 'struct fw_cdev_iso_packet' has no member named 'tag'
raw1394-iso.c:48: error: 'struct fw_cdev_iso_packet' has no member named 'sy'
raw1394-iso.c:49: error: 'struct fw_cdev_iso_packet' has no member named
The version in rawhide builds properly on F8, I just need to get around to pulling those same changes
Reopening. No one actually did a proper review here.
Oops, mah bad.
However, I can do a review quickly for you. :)
The only issues I see are:
1. The License tag is incorrect, it should be LGPLv2+.
2. You're using a tab separator on line 11, and spaces everywhere else.
Since these items are pedantic, and easily corrected in CVS, this package is
approved. Please commit those changes. :)
Here's the full review notes:
- rpmlint checks return:
libraw1394.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 11)
libraw1394.src: W: invalid-license LGPL
libraw1394.x86_64: W: invalid-license LGPL
libraw1394-devel.x86_64: W: invalid-license LGPL
libraw1394-debuginfo.x86_64: W: invalid-license LGPL
Needs fixing in CVS, not a blocker for review.
- package meets naming guidelines
- package meets packaging guidelines (except for license tag)
- license (LGPLv2+) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
- devel package ok
- no .la files
- post/postun ldconfig ok
- devel requires base package n-v-r
Thanks much, committed to rawhide cvs a few minutes ago.
Looks good! Closing this one out.