Bug 2260549
| Summary: | Review Request: qt6-qtgraphs - The Qt Graphs module enables you to visualize data in 3D | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Steve Cossette <farchord> | ||||
| Component: | Package Review | Assignee: | Alessandro Astone <ales.astone> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | ales.astone, package-review | ||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||
| Target Release: | --- | Flags: | ales.astone:
fedora-review+
|
||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| URL: | https://doc.qt.io/qt-6/qtgraphs-index.html | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2024-01-27 12:52:06 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Steve Cossette
2024-01-26 19:37:30 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/6965098 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2260549-qt6-qtgraphs/fedora-rawhide-x86_64/06965098-qt6-qtgraphs/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. For some reason, the srpm had an older version of the spec inside it. Updated. [fedora-review-service-build] Copr build: https://copr.fedorainfracloud.org/coprs/build/6965142 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2260549-qt6-qtgraphs/fedora-rawhide-x86_64/06965142-qt6-qtgraphs/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://farchord.fedorapeople.org/reviews/qt6-qtgraphs/qt6-qtgraphs.spec SRPM URL: https://farchord.fedorapeople.org/reviews/qt6-qtgraphs/qt6-qtgraphs-6.6.1-1.fc40.src.rpm Updated spec and srpm Created attachment 2010820 [details]
The .spec file difference from Copr build 6965142 to 6965177
Copr build: https://copr.fedorainfracloud.org/coprs/build/6965177 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2260549-qt6-qtgraphs/fedora-rawhide-x86_64/06965177-qt6-qtgraphs/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Package builds and installs.
Package follows fedora guidelines.
Licensing is correct.
No issues from fedora-review tool.
One nit pick: the project doesn't provide tests so %ctest can be removed.
> Test project /builddir/build/BUILD/qtgraphs-everywhere-src-6.6.1/redhat-linux-build
> No tests were found!!!
I should have written this in the previous comment, but package is APPROVED Thank you for the review, Alessandro The Pagure repository was created at https://src.fedoraproject.org/rpms/qt6-qtgraphs |