Spec URL: https://farchord.fedorapeople.org/reviews/qt6-qtgraphs/qt6-qtgraphs.spec SRPM URL: https://farchord.fedorapeople.org/reviews/qt6-qtgraphs/qt6-qtgraphs-6.6.1-1.src.rpm Description: The Qt Graphs module enables you to visualize data in 3D as bar, scatter, and surface graphs. It's especially useful for visualizing depth maps and large quantities of rapidly changing data, such as data received from multiple sensors. The look and feel of graphs can be customized by using themes or by adding custom items and labels. Qt Graphs is built on Qt 6 and Qt Quick 3D to take advantage of hardware acceleration and Qt Quick. Fedora Account System Username: farchord
Copr build: https://copr.fedorainfracloud.org/coprs/build/6965098 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2260549-qt6-qtgraphs/fedora-rawhide-x86_64/06965098-qt6-qtgraphs/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
For some reason, the srpm had an older version of the spec inside it. Updated. [fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/6965142 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2260549-qt6-qtgraphs/fedora-rawhide-x86_64/06965142-qt6-qtgraphs/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://farchord.fedorapeople.org/reviews/qt6-qtgraphs/qt6-qtgraphs.spec SRPM URL: https://farchord.fedorapeople.org/reviews/qt6-qtgraphs/qt6-qtgraphs-6.6.1-1.fc40.src.rpm Updated spec and srpm
Created attachment 2010820 [details] The .spec file difference from Copr build 6965142 to 6965177
Copr build: https://copr.fedorainfracloud.org/coprs/build/6965177 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2260549-qt6-qtgraphs/fedora-rawhide-x86_64/06965177-qt6-qtgraphs/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package builds and installs. Package follows fedora guidelines. Licensing is correct. No issues from fedora-review tool. One nit pick: the project doesn't provide tests so %ctest can be removed. > Test project /builddir/build/BUILD/qtgraphs-everywhere-src-6.6.1/redhat-linux-build > No tests were found!!!
I should have written this in the previous comment, but package is APPROVED
Thank you for the review, Alessandro
The Pagure repository was created at https://src.fedoraproject.org/rpms/qt6-qtgraphs