Bug 226069
| Summary: | Merge Review: libXevie | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nobody's working on this, feel free to take it <nobody> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | christoph.wickert, panemade, sandmann |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-10-21 06:25:55 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Nobody's working on this, feel free to take it
2007-01-31 19:30:13 UTC
Review: + koji build =>http://koji.fedoraproject.org/koji/buildinfo?buildID=135672 + verified upstream source as d22fd24d8f096fdff54d303d63fea1422f0cfeea libXevie-1.0.2.tar.bz2 + rpmlint is silent. + PAckage libXevie-1.0.2-8.fc13.i686 => Provides: libXevie.so.1 Requires: libX11.so.6 libXevie.so.1 libXext.so.6 libc.so.6 libc.so.6(GLIBC_2.1.3) rtld(GNU_HASH) + Package libXevie-devel-1.0.2-8.fc13.i686=> Provides: pkgconfig(xevie) = 1.0.2 Requires: /usr/bin/pkg-config libXevie.so.1 pkgconfig(x11) pkgconfig(xext) pkgconfig(xproto) APPROVED. Ok, now I understood that you are using sha1sums for verifying the source indead of md5sum. If you do things different from the review guidelines, this should be documented in the review. One thing that I noticed: -devel package is missing Requires: for libX11-devel, libXext-devel and xorg-x11-proto-devel. Thanks for your comment. I will make changes and build new release. (In reply to comment #2) > Ok, now I understood that you are using sha1sums for verifying the source > indead of md5sum. If you do things different from the review guidelines, this > should be documented in the review. > > One thing that I noticed: -devel package is missing Requires: for libX11-devel, > libXext-devel and xorg-x11-proto-devel. Ah! you mean Requires.private need to be included as Requires: in -devel? If yes then same will be applied to libXcursor right? (In reply to comment #4) > Ah! you mean Requires.private need to be included as Requires: in -devel? IMHO yes, without it, it's not possible to use the devel package properly. > If yes then same will be applied to libXcursor right? Indeed, I missed that. Christoph Wickert, as per discussed here https://www.redhat.com/archives/fedora-devel-list/2009-October/msg00530.html I am approving this package and closing this review. If any problem still seen please comment here. |