Bug 226140
| Summary: | Merge Review: microcode_ctl | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nobody's working on this, feel free to take it <nobody> | ||||
| Component: | microcode_ctl | Assignee: | Anton Arapov <anton> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 23 | CC: | anton, collura, jcm, jonathan, mattdm, nobody | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | microcode_ctl-2.1-10 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2016-01-12 14:48:55 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Nobody's working on this, feel free to take it
2007-01-31 19:40:31 UTC
Anton,
I see from changelog you did some few updates. So here I am suggesting some changes in spec that are required as per current packaging guidelines.
1) Group and Buildroot tag is not needed now. Remove those lines.
2) removal of buildroot in %install not needed
rm -rf %{buildroot}
3) %clean is not needed
4) make command and your %files section should use macros. Below is %files section
%files
%{_sbindir}/intel-microcode2ucode
/%{_lib}/firmware/*
%doc /usr/share/doc/microcode_ctl/*
5) rpmlint on rpms show
microcode_ctl.x86_64: W: summary-ended-with-dot C Tool to transform and deploy CPU microcode update for x86.
=> remove ending dot in summary
fix above issues. Build new package in master.
Please prepare the patch against the upstream tree(*) - I will review it and apply later on if everything is ok. * https://git.fedorahosted.org/cgit/microcode_ctl.git/tree/microcode_ctl.spec?h=obsolete Created attachment 823930 [details]
spec cleanup as per current packaging guidelines
any update here? Oh, overlooked the patch you've attached last year. Apologizes. I will push it upstream a bit later. Thanks! The general workflow for any kind of (merge/package/rename) review is to keep review bug assigned to the person who is going to finally approve the review. But for tracking purposes if you want this review bug assigned to you then its ok just don't forget to assign me back once you done with package update for further package review. ping any updates? or allow to commit the patch to me. Mass reassigning all merge reviews to their component. For more details, see this FESCO ticket: https://fedorahosted.org/fesco/ticket/1269 If you don't know what merge reviews are about, please see: https://fedoraproject.org/wiki/Merge_Reviews How to handle this bug is left to the discretion of the package maintainer. This bug appears to have been reported against 'rawhide' during the Fedora 23 development cycle. Changing version to '23'. (As we did not run this process for some time, it could affect also pre-Fedora 23 development cycle bugs. We are very sorry. It will help us with cleanup during Fedora 23 End Of Life. Thank you.) More information and reason for this action is here: https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora23 The issues from the Comment#1 have been addressed. |