Bug 2262276

Summary:	Review Request: amazon-ssm-agent - Amazon EC2 Simple Systems Manager (SSM) Agent
Product:	[Fedora] Fedora	Reporter:	Major Hayden 🤠 <mhayden>
Component:	Package Review	Assignee:	Neal Gompa <ngompa13>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	davdunc, dominik, domwom, ngompa13, package-review
Target Milestone:	---	Flags:	ngompa13: fedora-review?
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-04-17 20:49:19 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Major Hayden 🤠 2024-02-01 14:20:02 UTC

Spec URL: https://mhayden.fedorapeople.org/amazon-ssm-agent.spec
SRPM URL: https://mhayden.fedorapeople.org/amazon-ssm-agent-3.2.2143.0-1.fc39.src.rpm

Description:
An agent to enable remote management of your EC2 instances, on-premises
servers, or virtual machines (VMs).

Fedora Account System Username: mhayden

Comment 1 Fedora Review Service 2024-02-01 14:49:08 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6979620
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2262276-amazon-ssm-agent/fedora-rawhide-x86_64/06979620-amazon-ssm-agent/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Neal Gompa 2024-02-01 16:19:53 UTC

Taking this review.

Comment 3 Neal Gompa 2024-02-13 23:48:09 UTC

Initial perusal of the sources gives me a few pauses for concern:

* it looks like there's a systemd unit: https://github.com/aws/amazon-ssm-agent/blob/mainline/packaging/linux/amazon-ssm-agent.service

the systemd unit should have a "ConditionVirtualization=amazon" stanza so it doesn't activate on non-AWS. Additionally, we need a preset for this.

* this stuff makes me nervous: 
** https://github.com/aws/amazon-ssm-agent/tree/mainline/agent/plugins/configurepackage
** https://github.com/aws/amazon-ssm-agent/tree/mainline/agent/plugins/downloadcontent

* this selfupdate code needs to be killed: https://github.com/aws/amazon-ssm-agent/blob/mainline/agent/plugins/updatessmagent/updateagent.go

can you please take a look at this further?

Comment 4 Major Hayden 🤠 2024-04-17 20:49:19 UTC

Going to withdraw this for now until we have good Fedora support in the SSM agent.