Spec URL: https://mhayden.fedorapeople.org/amazon-ssm-agent.spec SRPM URL: https://mhayden.fedorapeople.org/amazon-ssm-agent-3.2.2143.0-1.fc39.src.rpm Description: An agent to enable remote management of your EC2 instances, on-premises servers, or virtual machines (VMs). Fedora Account System Username: mhayden
Copr build: https://copr.fedorainfracloud.org/coprs/build/6979620 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2262276-amazon-ssm-agent/fedora-rawhide-x86_64/06979620-amazon-ssm-agent/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Taking this review.
Initial perusal of the sources gives me a few pauses for concern: * it looks like there's a systemd unit: https://github.com/aws/amazon-ssm-agent/blob/mainline/packaging/linux/amazon-ssm-agent.service the systemd unit should have a "ConditionVirtualization=amazon" stanza so it doesn't activate on non-AWS. Additionally, we need a preset for this. * this stuff makes me nervous: ** https://github.com/aws/amazon-ssm-agent/tree/mainline/agent/plugins/configurepackage ** https://github.com/aws/amazon-ssm-agent/tree/mainline/agent/plugins/downloadcontent * this selfupdate code needs to be killed: https://github.com/aws/amazon-ssm-agent/blob/mainline/agent/plugins/updatessmagent/updateagent.go can you please take a look at this further?
Going to withdraw this for now until we have good Fedora support in the SSM agent.