| Summary: | Merge Review: perl-Net-IP | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nobody's working on this, feel free to take it <nobody> |
| Component: | Package Review | Assignee: | Robin Norwood <robin.norwood> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | bochecha, redhat-bugzilla, robin.norwood, ville.skytta |
| Target Milestone: | --- | Flags: | ville.skytta:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-02-26 23:40:08 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Nobody's working on this, feel free to take it
2007-01-31 20:36:45 UTC
Just a couple of small issues that can be fixed directly in CVS, no need for a review roundtrip: - Source URL is broken (missing slash), should be "ftp://cpan...", not "ftp:/cpan..." - Change "-type d -depth" to "-depth -type d" in %install to avoid a (discarded) warning from find(1). Thanks for the review, Ville.
I noticed a couple of other things that I fixed as well:
o rpmlint complained about mixed-spaces-and-tabs. Fixed.
o Removed the redundant BuildRequires: perl
o Fixed the Release: to include magic %{?dist} macro
Built new package for FC7. Let me know what you think. Looks good, although even if currently redundant with today's specified minimal Fedora buildroot package lists, I would have kept the perl build dependency (I don't expect it to stick around in the list of "assumed present" packages forever). But that's just a personal preference. Package Change Request ====================== Package Name: perl-Net-IP New Branches: EL-4 Updated EPEL Owners: kasal mmaslano Updated EPEL CC: perl-sig cvs done. Closing... (merge review with fedora-review+) This package is in EPEL4, but not in EPEL5 and 6. Is there any reason for that? I would like to see this package in EPEL6, and I am willing to help co-maintain it. Because the package is in Red Hat Enterprise Linux 5 and 6. |