Fedora Merge Review: perl-Net-IP http://cvs.fedora.redhat.com/viewcvs/devel/perl-Net-IP/ Initial Owner: rnorwood
Just a couple of small issues that can be fixed directly in CVS, no need for a review roundtrip: - Source URL is broken (missing slash), should be "ftp://cpan...", not "ftp:/cpan..." - Change "-type d -depth" to "-depth -type d" in %install to avoid a (discarded) warning from find(1).
Thanks for the review, Ville. I noticed a couple of other things that I fixed as well: o rpmlint complained about mixed-spaces-and-tabs. Fixed. o Removed the redundant BuildRequires: perl o Fixed the Release: to include magic %{?dist} macro
Built new package for FC7. Let me know what you think.
Looks good, although even if currently redundant with today's specified minimal Fedora buildroot package lists, I would have kept the perl build dependency (I don't expect it to stick around in the list of "assumed present" packages forever). But that's just a personal preference.
Package Change Request ====================== Package Name: perl-Net-IP New Branches: EL-4 Updated EPEL Owners: kasal mmaslano Updated EPEL CC: perl-sig
cvs done.
Closing... (merge review with fedora-review+)
This package is in EPEL4, but not in EPEL5 and 6. Is there any reason for that? I would like to see this package in EPEL6, and I am willing to help co-maintain it.
Because the package is in Red Hat Enterprise Linux 5 and 6.