Bug 2262767

Summary:	Review Request: ghc-config-value - Simple, layout-based value language similar to YAML or JSON
Product:	[Fedora] Fedora	Reporter:	Frank Dedden <frank>
Component:	Package Review	Assignee:	Jens Petersen <petersen>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	haskell-devel, package-review
Target Milestone:	---	Flags:	petersen: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
URL:	https://hackage.haskell.org/package/%{pkg_name}
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-07-01 09:47:11 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Frank Dedden 2024-02-05 11:09:13 UTC

Spec URL: https://fdedden.fedorapeople.org/ghc-config-value.spec
SRPM URL: https://fdedden.fedorapeople.org/ghc-config-value-0.8.3-1.fc40.src.rpm

Description:
This package implements a language similar to YAML or JSON but with fewer
special cases and fewer dependencies. It emphasizes layout structure for
sections and lists, and requires quotes around strings.

Fedora Account System Username: fdedden

Comment 1 Frank Dedden 2024-02-05 11:09:16 UTC

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=112967138

Comment 2 Frank Dedden 2024-02-05 11:15:36 UTC

I had to modify the .spec file generated by `cabal-rpm` to include `alex` and `happy` dependencies (uncomment the `BuildRequires` files) to have this build successfully. Now they are dependencies to the `.rpm` file, but I am not sure they are necessary during usage of the library.

Comment 3 Fedora Review Service 2024-02-05 11:19:51 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6986277
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2262767-ghc-config-value/fedora-rawhide-x86_64/06986277-ghc-config-value/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Jens Petersen 2024-05-27 17:00:56 UTC

Thanks, overall looks fine to me.

The package complies with the packaging guidelines, builds and installs.
Spec file is generated with cabal-rpm.

However the license file is MIT, but many of the source files say ISC (except .cabal).
Could you confirm the license with the upstream maintainer, please?
(I know ISC and MIT are quite similar but we need to be precise in Fedora:
in the worst case we could possibly go with "MIT AND ISC" as workaround but that feels wrong:
maybe ISC is more correct actually here by the looks of it.)

Comment 5 Jens Petersen 2024-05-30 05:07:38 UTC

(In reply to Jens Petersen from comment #4)
> Thanks, overall looks fine to me.
> 
> The package complies with the packaging guidelines, builds and installs.
> Spec file is generated with cabal-rpm.
> 
> However the license file is MIT, but many of the source files say ISC
> (except .cabal).
> Could you confirm the license with the upstream maintainer, please?
> (I know ISC and MIT are quite similar but we need to be precise in Fedora:
> in the worst case we could possibly go with "MIT AND ISC" as workaround but
> that feels wrong:
> maybe ISC is more correct actually here by the looks of it.)

Indeed: https://github.com/glguy/config-value/issues/13

So either add a link to this issue above the corrected License field,
or update to the newer release if that comes out first and is compatible.

Comment 6 Frank Dedden 2024-06-01 09:32:52 UTC

[fedora-review-service-build]

Thanks Jens, I have updated the .spec file.

Comment 7 Frank Dedden 2024-06-01 09:40:37 UTC

Rebuilding does not seem to work, maybe this does.

Spec URL: https://fdedden.fedorapeople.org/ghc-config-value.spec
SRPM URL: https://fdedden.fedorapeople.org/ghc-config-value-0.8.3-1.fc41.src.rpm

Comment 8 Jens Petersen 2024-06-11 15:29:23 UTC

Thanks - looks good now, Frank.

BTW next time it better to bump the release field with a changelog comment when revising a package review

Package is APPROVED

Comment 9 Fedora Admin user for bugzilla script actions 2024-06-24 09:02:20 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/ghc-config-value

Comment 10 Frank Dedden 2024-06-24 09:27:53 UTC

I have adjusted the changelog as you mentioned. Package has been build successfully and is waiting to be picked up for inclusion in rawhide.