Spec URL: https://fdedden.fedorapeople.org/ghc-config-value.spec SRPM URL: https://fdedden.fedorapeople.org/ghc-config-value-0.8.3-1.fc40.src.rpm Description: This package implements a language similar to YAML or JSON but with fewer special cases and fewer dependencies. It emphasizes layout structure for sections and lists, and requires quotes around strings. Fedora Account System Username: fdedden
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=112967138
I had to modify the .spec file generated by `cabal-rpm` to include `alex` and `happy` dependencies (uncomment the `BuildRequires` files) to have this build successfully. Now they are dependencies to the `.rpm` file, but I am not sure they are necessary during usage of the library.
Copr build: https://copr.fedorainfracloud.org/coprs/build/6986277 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2262767-ghc-config-value/fedora-rawhide-x86_64/06986277-ghc-config-value/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Thanks, overall looks fine to me. The package complies with the packaging guidelines, builds and installs. Spec file is generated with cabal-rpm. However the license file is MIT, but many of the source files say ISC (except .cabal). Could you confirm the license with the upstream maintainer, please? (I know ISC and MIT are quite similar but we need to be precise in Fedora: in the worst case we could possibly go with "MIT AND ISC" as workaround but that feels wrong: maybe ISC is more correct actually here by the looks of it.)
(In reply to Jens Petersen from comment #4) > Thanks, overall looks fine to me. > > The package complies with the packaging guidelines, builds and installs. > Spec file is generated with cabal-rpm. > > However the license file is MIT, but many of the source files say ISC > (except .cabal). > Could you confirm the license with the upstream maintainer, please? > (I know ISC and MIT are quite similar but we need to be precise in Fedora: > in the worst case we could possibly go with "MIT AND ISC" as workaround but > that feels wrong: > maybe ISC is more correct actually here by the looks of it.) Indeed: https://github.com/glguy/config-value/issues/13 So either add a link to this issue above the corrected License field, or update to the newer release if that comes out first and is compatible.
[fedora-review-service-build] Thanks Jens, I have updated the .spec file.
Rebuilding does not seem to work, maybe this does. Spec URL: https://fdedden.fedorapeople.org/ghc-config-value.spec SRPM URL: https://fdedden.fedorapeople.org/ghc-config-value-0.8.3-1.fc41.src.rpm
Thanks - looks good now, Frank. BTW next time it better to bump the release field with a changelog comment when revising a package review Package is APPROVED
The Pagure repository was created at https://src.fedoraproject.org/rpms/ghc-config-value
I have adjusted the changelog as you mentioned. Package has been build successfully and is waiting to be picked up for inclusion in rawhide.