Bug 2262808

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6986687
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2262808-php-sebastian-recursion-context6/fedora-rawhide-x86_64/06986687-php-sebastian-recursion-context6/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Please drop in %%files section:
# remirepo:1
%{!?_licensedir:%global license %%doc}

Otherwise looks good, full review incoming.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "BSD 3-Clause License", "*No copyright*
     BSD 3-Clause License". 13 files have unknown license. Detailed output
     of licensecheck in /tmp/2262808-php-sebastian-recursion-
     context6/licensecheck.txt
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/php
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 2282 bytes in 2 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

PHP:
[x]: Run phpci static analyze on all php files.
     Note: usage /usr/share/php-bartlett-PHP-CompatInfo/fedora-review-check
     logname dirname 7.1.2@072d0f8 static analyze results in
     /tmp/2262808-php-sebastian-recursion-context6/phpci.log


Rpmlint
-------
Checking: php-sebastian-recursion-context6-6.0.0-1.fc41.noarch.rpm
          php-sebastian-recursion-context6-6.0.0-1.fc41.src.rpm
======================================================================================================== rpmlint session starts =======================================================================================================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpa3qxhgao')]
checks: 32, packages: 2

php-sebastian-recursion-context6.noarch: E: spelling-error ('Autoloader', '%description -l en_US Autoloader -> Auto loader, Auto-loader, Freeloader')
php-sebastian-recursion-context6.noarch: E: spelling-error ('autoload', '%description -l en_US autoload -> auto load, auto-load, tautology')
php-sebastian-recursion-context6.src: E: spelling-error ('Autoloader', '%description -l en_US Autoloader -> Auto loader, Auto-loader, Freeloader')
php-sebastian-recursion-context6.src: E: spelling-error ('usr', '%description -l en_US usr -> use, us, user')
php-sebastian-recursion-context6.src: E: spelling-error ('autoload', '%description -l en_US autoload -> auto load, auto-load, tautology')
php-sebastian-recursion-context6.spec: W: invalid-url Source0: php-sebastian-recursion-context6-6.0.0-b752249.tgz
=================================================================== 2 packages and 0 specfiles checked; 5 errors, 1 warnings, 7 filtered, 5 badness; has taken 0.3 s ==================================================================




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

php-sebastian-recursion-context6.noarch: E: spelling-error ('Autoloader', '%description -l en_US Autoloader -> Auto loader, Auto-loader, Freeloader')
php-sebastian-recursion-context6.noarch: E: spelling-error ('autoload', '%description -l en_US autoload -> auto load, auto-load, tautology')
 1 packages and 0 specfiles checked; 2 errors, 0 warnings, 3 filtered, 2 badness; has taken 0.1 s 



Requires
--------
php-sebastian-recursion-context6 (rpmlib, GLIBC filtered):
    php(language)
    php-composer(fedora/autoloader)
    php-spl



Provides
--------
php-sebastian-recursion-context6:
    php-composer(sebastian/recursion-context)
    php-sebastian-recursion-context6



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2262808
Buildroot used: fedora-rawhide-x86_64
Active plugins: PHP, Shell-api, Generic
Disabled plugins: Ocaml, Python, Perl, R, Java, Haskell, C/C++, fonts, SugarActivity
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

package is APPROVED.

Oh, and please add a comment about the upstream tarball shipped without tests.

The Pagure repository was created at https://src.fedoraproject.org/rpms/php-sebastian-recursion-context6

Thanks for the review

SCM requests

https://pagure.io/releng/fedora-scm-requests/issue/60863
https://pagure.io/releng/fedora-scm-requests/issue/60864
https://pagure.io/releng/fedora-scm-requests/issue/60865

> Oh, and please add a comment about the upstream tarball shipped without tests.

https://src.fedoraproject.org/rpms/php-sebastian-recursion-context6/c/bfbaccf8ccbdb236f74c6cb764590071436b7dd5?branch=rawhide

FEDORA-2024-2d1c3c2743 (php-sebastian-recursion-context6-6.0.0-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-2d1c3c2743

FEDORA-2024-1e8fd8d497 (php-sebastian-recursion-context6-6.0.0-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-1e8fd8d497

FEDORA-2024-1e8fd8d497 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-1e8fd8d497 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-1e8fd8d497

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2024-2d1c3c2743 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-2d1c3c2743 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-2d1c3c2743

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2024-2d1c3c2743 (php-sebastian-recursion-context6-6.0.0-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2024-1e8fd8d497 (php-sebastian-recursion-context6-6.0.0-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.