Spec URL: https://git.remirepo.net/cgit/rpms/php/phpunit/php-sebastian-exporter6.git/plain/php-sebastian-exporter6.spec?id=7419709d3eebcfb072bad5752b79ae1adce72311 SRPM URL: https://rpms.remirepo.net/SRPMS/php-sebastian-exporter6-6.0.0-1.remi.src.rpm Description: Provides the functionality to export PHP variables for visualization. This package provides version 6 of sebastian/exporter library. Autoloader: /usr/share/php/SebastianBergmann/Exporter6/autoload.php Fedora Account System Username: remi Previous version review bug #2168101
Copr build: https://copr.fedorainfracloud.org/coprs/build/6986692 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2262810-php-sebastian-exporter6/fedora-rawhide-x86_64/06986692-php-sebastian-exporter6/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Update to 6.0.1 Spec URL: https://git.remirepo.net/cgit/rpms/php/phpunit/php-sebastian-exporter6.git/plain/php-sebastian-exporter6.spec?id=f85041d15de86eef3754a106b2ac74016be845f3 SRPM URL: https://rpms.remirepo.net/SRPMS/php-sebastian-exporter6-6.0.1-1.remi.src.rpm
Created attachment 2020188 [details] The .spec file difference from Copr build 6986692 to 7107044
Copr build: https://copr.fedorainfracloud.org/coprs/build/7107044 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2262810-php-sebastian-exporter6/fedora-rawhide-x86_64/07107044-php-sebastian-exporter6/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
- Add a comment about the upstream tarball missing tests - Drop '# remirepo:*' comments - The conditional : ``` %if 0%{?fedora} >= 27 || 0%{?rhel} >= 8 BuildRequires: (php-composer(%{pk_vendor}/recursion-context) >= 6.0 with php-composer(%{pk_vendor}/recursion-context) < 7) %else BuildRequires: php-sebastian-recursion-context6 %endif ``` Could be rewritten as : ``` %if %{?el7} BuildRequires: php-sebastian-recursion-context6 %else BuildRequires: (php-composer(%{pk_vendor}/recursion-context) >= 6.0 with php-composer(%{pk_vendor}/recursion-context) < 7) %endif ``` But does EL7 still carry value at this point ? - Drop `%{!?_licensedir:%global license %%doc}` in %files Otherwise looks good. Full review incoming.
Please remind that all the stuff needed for all versions (EL-7 and my repository) are auto-removed during import in Fedora repo Ex, see https://src.fedoraproject.org/rpms/php-sebastian-exporter5/commits/rawhide Especially the cleanup commit: https://src.fedoraproject.org/rpms/php-sebastian-exporter5/c/e1ec1d8b84da7bad2c80baebed36f546a13589cc?branch=rawhide Please ignore them Else I will have to duplicate all the spec files for the review
Update to 6.0.1 Spec URL: https://git.remirepo.net/cgit/rpms/php/phpunit/php-sebastian-exporter6.git/plain/php-sebastian-exporter6.spec?id=02e276b159e92eb0dd51144b1b9b64b8e1c4bc08 SRPM URL: https://rpms.remirepo.net/SRPMS/php-sebastian-exporter6-6.1.2-1.remi.src.rpm
Created attachment 2038690 [details] The .spec file difference from Copr build 7107044 to 7697938
Copr build: https://copr.fedorainfracloud.org/coprs/build/7697938 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2262810-php-sebastian-exporter6/fedora-rawhide-x86_64/07697938-php-sebastian-exporter6/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Update to 6.1.3 Spec URL: https://git.remirepo.net/cgit/rpms/php/phpunit/php-sebastian-exporter6.git/plain/php-sebastian-exporter6.spec?id=8efa7768a3d9e418ba3900b7937a9334afdd25f4 SRPM URL: https://rpms.remirepo.net/SRPMS/php-sebastian-exporter6-6.1.3-1.remi.src.rpm
Created attachment 2038731 [details] The .spec file difference from Copr build 7697938 to 7699805
Copr build: https://copr.fedorainfracloud.org/coprs/build/7699805 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2262810-php-sebastian-exporter6/fedora-rawhide-x86_64/07699805-php-sebastian-exporter6/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Update to 6.2.0 Spec URL: https://git.remirepo.net/cgit/rpms/php/phpunit/php-sebastian-exporter6.git/plain/php-sebastian-exporter6.spec?id=1d75c9dc08c5f2085035098528e9ffa2d9c7ac29 SRPM URL: https://rpms.remirepo.net/SRPMS/php-sebastian-exporter6-6.2.0-1.remi.src.rpm
Created attachment 2061328 [details] The .spec file difference from Copr build 7699805 to 8343555
Copr build: https://copr.fedorainfracloud.org/coprs/build/8343555 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2262810-php-sebastian-exporter6/fedora-rawhide-x86_64/08343555-php-sebastian-exporter6/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Update to 6.3.0 Spec URL: https://git.remirepo.net/cgit/rpms/php/phpunit/php-sebastian-exporter6.git/plain/php-sebastian-exporter6.spec?id=cf28366d1aefe15c9563136e11edcd9765af90db SRPM URL: https://rpms.remirepo.net/SRPMS/php-sebastian-exporter6-6.3.0-1.remi.src.rpm
Created attachment 2061329 [details] The .spec file difference from Copr build 8343555 to 8343825
Copr build: https://copr.fedorainfracloud.org/coprs/build/8343825 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2262810-php-sebastian-exporter6/fedora-rawhide-x86_64/08343825-php-sebastian-exporter6/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Reviewx exception https://pagure.io/releng/fedora-scm-requests/issue/71933