Bug 226348
| Summary: | Merge Review: python-virtinst | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nobody's working on this, feel free to take it <nobody> |
| Component: | Package Review | Assignee: | David Lutterkort <lutter> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | berrange, crobinso, hbrock, katzj, markmc, virt-maint |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-02-12 14:20:06 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Nobody's working on this, feel free to take it
2007-01-31 20:47:06 UTC
Review based on http://koji.fedoraproject.org/packages/python-virtinst/0.103.0/3.fc7/src/python-virtinst-0.103.0-3.fc7.src.rpm Specfile looks ok overall. Small comments - Not strictly necessary here, but we encourage people to use %global instead of %define in spec files (http://fedoraproject.org/wiki/PackagingDrafts/global_preferred_over_define) - Source0 needs to be a complete URL to the released source tarball - Should the provide of virtinst be versioned ? rpmlint says: E: python-virtinst non-executable-script /usr/lib/python2.5/site-packages/virtinst/ParaVirtGuest.py 0644 E: python-virtinst non-executable-script /usr/lib/python2.5/site-packages/virtinst/DistroManager.py 0644 E: python-virtinst non-executable-script /usr/lib/python2.5/site-packages/virtinst/Guest.py 0644 E: python-virtinst non-executable-script /usr/lib/python2.5/site-packages/virtinst/FullVirtGuest.py 0644 E: python-virtinst non-executable-script /usr/lib/python2.5/site-packages/virtinst/util.py 0644 Strip the #!/usr/bin/python from those files; seems unnecessary, anyway W: python-virtinst obsolete-not-provided python-xeninst Should be fixed (In reply to comment #1) > - Should the provide of virtinst be versioned ? Can't hurt. > W: python-virtinst obsolete-not-provided python-xeninst > Should be fixed python-xeninst _isn't_ provided, though. That API was 'import xeninst'. At this point, we can probably just drop the obsolete entirely, though. python-xeninst was the name before we made it more generic as virtinst. But that was only ever in rawhide. Cole, could you take care of the above spec changes so we can get the review finished ? These fixes will be in the new rawhide build python-virtinst-0_300_2-1_fc9 closing |