Bug 226348 - Merge Review: python-virtinst
Merge Review: python-virtinst
Status: CLOSED CURRENTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: David Lutterkort
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 15:47 EST by Nobody's working on this, feel free to take it
Modified: 2013-04-30 19:40 EDT (History)
6 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-02-12 09:20:06 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 15:47:06 EST
Fedora Merge Review: python-virtinst

http://cvs.fedora.redhat.com/viewcvs/devel/python-virtinst/
Initial Owner: katzj@redhat.com
Comment 1 David Lutterkort 2007-05-03 18:25:20 EDT
Review based on
http://koji.fedoraproject.org/packages/python-virtinst/0.103.0/3.fc7/src/python-virtinst-0.103.0-3.fc7.src.rpm

Specfile looks ok overall. Small comments

- Not strictly necessary here, but we encourage people to use %global instead of
%define in spec files
(http://fedoraproject.org/wiki/PackagingDrafts/global_preferred_over_define)

- Source0 needs to be a complete URL to the released source tarball

- Should the provide of virtinst be versioned ?

rpmlint says:

  E: python-virtinst non-executable-script
/usr/lib/python2.5/site-packages/virtinst/ParaVirtGuest.py 0644
  E: python-virtinst non-executable-script
/usr/lib/python2.5/site-packages/virtinst/DistroManager.py 0644
  E: python-virtinst non-executable-script
/usr/lib/python2.5/site-packages/virtinst/Guest.py 0644
  E: python-virtinst non-executable-script
/usr/lib/python2.5/site-packages/virtinst/FullVirtGuest.py 0644
  E: python-virtinst non-executable-script
/usr/lib/python2.5/site-packages/virtinst/util.py 0644

Strip the #!/usr/bin/python from those files; seems unnecessary, anyway

  W: python-virtinst obsolete-not-provided python-xeninst

Should be fixed
Comment 2 Jeremy Katz 2007-05-03 19:25:27 EDT
(In reply to comment #1)
> - Should the provide of virtinst be versioned ?

Can't hurt.

>   W: python-virtinst obsolete-not-provided python-xeninst 
> Should be fixed

python-xeninst _isn't_ provided, though.  That API was 'import xeninst'.  At
this point, we can probably just drop the obsolete entirely, though. 
python-xeninst was the name before we made it more generic as virtinst.  But
that was only ever in rawhide.


Comment 3 David Lutterkort 2008-01-10 18:34:14 EST
Cole, could you take care of the above spec changes so we can get the review
finished ?
Comment 4 Daniel Berrange 2008-01-10 21:06:11 EST
These fixes will be in the new rawhide build python-virtinst-0_300_2-1_fc9
Comment 5 Mark McLoughlin 2009-02-12 09:20:06 EST
closing

Note You need to log in before you can comment on or make changes to this bug.