Bug 2263942

Summary: Review Request: rust-ureq - Simple, safe HTTP client
Product: [Fedora] Fedora Reporter: Michel Lind <michel>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: decathorpe, package-review, thunderbirdtr
Target Milestone: ---Flags: decathorpe: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://crates.io/crates/ureq
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-02-15 17:15:29 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2263940    
Bug Blocks: 2211172, 2263954    
Attachments:
Description Flags
The .spec file difference from Copr build 7010721 to 7012573 none

Description Michel Lind 2024-02-12 22:08:03 UTC
Spec URL: https://salimma.fedorapeople.org/specs/rust-ureq.spec
SRPM URL: https://salimma.fedorapeople.org/specs/rust-ureq-2.9.1-1.fc39.src.rpm

Description:
Simple, safe HTTP client.

Fedora Account System Username: salimma

Comment 1 Michel Lind 2024-02-12 22:12:11 UTC
*** Bug 2256434 has been marked as a duplicate of this bug. ***

Comment 2 Fabio Valentini 2024-02-12 22:42:44 UTC
Two small issues:

- The project seems to contain a code copy-pasted / forked from tiny-http or rust-chunked-transfer, which is Apache-2.0-only. According to our legal guidelines, that means the license in metadata should be "(MIT OR Apache-2.0) AND Apache-2.0" instead of just "MIT OR Apache-2.0".

- The crate includes a bunch of files that are unnecessary for packaging, and some that cause minor issues. For example, the shell scripts cause a dependency on /usr/bin/bash to be generated, which we don't want. Please exclude the unnecessary files (i.e. by adding something like `exclude = ["/cargo_deny.sh", "/deny.toml", "/test.sh"]` to the [package] table in Cargo.toml.

Comment 3 Fabio Valentini 2024-02-12 22:45:11 UTC
To clarify the first point, the code in question seems to be the contents of the "src/chunked/" directory, which also includes the separate license file.

Comment 4 Fedora Review Service 2024-02-13 00:12:09 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7010721
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2263942-rust-ureq/fedora-rawhide-x86_64/07010721-rust-ureq/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Michel Lind 2024-02-13 20:16:13 UTC
Review feedbacks addressed, thanks!

[fedora-review-service-build]

Comment 6 Fedora Review Service 2024-02-13 20:27:01 UTC
Created attachment 2016648 [details]
The .spec file difference from Copr build 7010721 to 7012573

Comment 7 Fedora Review Service 2024-02-13 20:27:04 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7012573
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2263942-rust-ureq/fedora-rawhide-x86_64/07012573-rust-ureq/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 8 Fabio Valentini 2024-02-14 19:10:37 UTC
Looks good to me now. fedora-review is somehow broken so I didn't get its full report, but the package looks fine.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
! latest version of the crate is packaged (more recent versions have more / more recent dependencies)
- license matches upstream specification and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 9 Fedora Admin user for bugzilla script actions 2024-02-15 16:36:36 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-ureq

Comment 10 Fedora Update System 2024-02-15 17:14:52 UTC
FEDORA-2024-61dad1a341 (rust-ureq-2.9.1-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-61dad1a341

Comment 11 Fedora Update System 2024-02-15 17:15:29 UTC
FEDORA-2024-61dad1a341 (rust-ureq-2.9.1-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2024-02-15 17:45:11 UTC
FEDORA-2024-3e167b07ad (rust-ureq-2.9.1-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-3e167b07ad

Comment 13 Fedora Update System 2024-02-15 17:48:32 UTC
FEDORA-2024-3e167b07ad (rust-ureq-2.9.1-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2024-02-15 18:52:58 UTC
FEDORA-2024-bed6420f1f (rust-ureq-2.9.1-1.fc38) has been submitted as an update to Fedora 38.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-bed6420f1f

Comment 15 Fedora Update System 2024-02-15 18:52:59 UTC
FEDORA-2024-9f2b2c3452 (rust-ureq-2.9.1-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-9f2b2c3452

Comment 16 Fedora Update System 2024-02-16 01:04:04 UTC
FEDORA-2024-bed6420f1f has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-bed6420f1f \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-bed6420f1f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 17 Fedora Update System 2024-02-16 01:16:22 UTC
FEDORA-2024-9f2b2c3452 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-9f2b2c3452 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-9f2b2c3452

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 18 Fedora Update System 2024-02-20 01:37:36 UTC
FEDORA-2024-bed6420f1f (rust-ureq-2.9.1-1.fc38) has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 19 Fedora Update System 2024-02-20 01:39:58 UTC
FEDORA-2024-9f2b2c3452 (rust-ureq-2.9.1-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.