Bug 2256434 - Review Request: rust-ureq - Simple, safe HTTP client
Summary: Review Request: rust-ureq - Simple, safe HTTP client
Keywords:
Status: CLOSED DUPLICATE of bug 2263942
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/ureq
Whiteboard:
: review-rust-ureq (view as bug list)
Depends On: 2122457 2249516
Blocks: itp-rust-nu-command
TreeView+ depends on / blocked
 
Reported: 2024-01-02 08:37 UTC by Onuralp Sezer
Modified: 2024-02-12 22:12 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-02-12 22:12:11 UTC
Type: ---
Embargoed:
decathorpe: fedora-review?


Attachments (Terms of Use)

Description Onuralp Sezer 2024-01-02 08:37:10 UTC
Spec URL: https://thunderbirdtr.fedorapeople.org/rust-ureq/rust-ureq.spec
SRPM URL: https://thunderbirdtr.fedorapeople.org/rust-ureq/rust-ureq-2.9.1-1.fc40.src.rpm
Description: Simple, safe HTTP client
Fedora Account System Username: thunderbirdtr

Comment 1 Onuralp Sezer 2024-01-02 13:40:03 UTC
*** Bug 2211432 has been marked as a duplicate of this bug. ***

Comment 2 Fedora Review Service 2024-01-02 15:32:14 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6848300
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2256434-rust-ureq/fedora-rawhide-x86_64/06848300-rust-ureq/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Neal Gompa 2024-01-03 14:14:00 UTC
Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- license correct and valid
- only sources installed

PACKAGE APPROVED.

Comment 4 Fabio Valentini 2024-01-03 14:20:16 UTC
Not so fast. The built packages are not installable:

Problem 1: conflicting requests
  - nothing provides (crate(cookie) >= 0.17.0 with crate(cookie) < 0.18.0~) needed by rust-ureq+cookies-devel-2.9.1-1.fc40.noarch
  - nothing provides (crate(cookie_store) >= 0.20.0 with crate(cookie_store) < 0.21.0~) needed by rust-ureq+cookies-devel-2.9.1-1.fc40.noarch
  - nothing provides (crate(cookie_store/preserve_order) >= 0.20.0 with crate(cookie_store/preserve_order) < 0.21.0~) needed by rust-ureq+cookies-devel-2.9.1-1.fc40.noarch
 Problem 2: conflicting requests
  - nothing provides (crate(http/default) >= 1.0.0 with crate(http/default) < 2.0.0~) needed by rust-ureq+http-crate-devel-2.9.1-1.fc40.noarch
 Problem 3: conflicting requests
  - nothing provides (crate(socks/default) >= 0.3.0 with crate(socks/default) < 0.4.0~) needed by rust-ureq+socks-proxy-devel-2.9.1-1.fc40.noarch

These need to be resolved one way or another.

Comment 5 Fabio Valentini 2024-01-10 13:39:33 UTC
I have just pushed updates for the cookie crate (v0.17.0), the cookie_store crate (v0.20.0) and the http crate (v1.0.0).
This resolves the first two of the "Problems" listed above.

For Problem No. 3, there are two solutions:
- either package the "socks" crate (version 0.3.*)
- or remove the socks-proxy functionality from this package (by patching out the "socks" dependency and the "socks-proxy" feature from Cargo.toml)

Comment 6 Michel Lind 2024-02-12 22:12:11 UTC

*** This bug has been marked as a duplicate of bug 2263942 ***


Note You need to log in before you can comment on or make changes to this bug.