Bug 2263954

Summary: Review Request: rust-nu-command - Nushell's built-in commands
Product: [Fedora] Fedora Reporter: Michel Lind <michel>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Flags: decathorpe: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://crates.io/crates/nu-command
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-02-15 20:33:28 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2211427, 2263942    
Bug Blocks:    

Description Michel Lind 2024-02-12 23:45:18 UTC
Spec URL: https://salimma.fedorapeople.org/specs/rust-nu-command.spec
SRPM URL: https://salimma.fedorapeople.org/specs/rust-nu-command-0.88.1-1.fc39.src.rpm

Description:
Nushell's built-in commands.

Fedora Account System Username: salimma

Comment 1 Fedora Review Service 2024-02-13 00:07:32 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7010716
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2263954-rust-nu-command/fedora-rawhide-x86_64/07010716-rust-nu-command/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2024-02-15 19:46:17 UTC
Looks good to me!

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
! latest version of the crate is packaged (needs to be updated together with the already packaged nu-* crates)
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 3 Michel Lind 2024-02-15 19:48:54 UTC
*** Bug 2211172 has been marked as a duplicate of this bug. ***

Comment 4 Fedora Admin user for bugzilla script actions 2024-02-15 19:49:58 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-nu-command

Comment 5 Fedora Update System 2024-02-15 20:30:52 UTC
FEDORA-2024-cbaf76c42e (rust-nu-command-0.88.1-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-cbaf76c42e

Comment 6 Fedora Update System 2024-02-15 20:33:28 UTC
FEDORA-2024-cbaf76c42e (rust-nu-command-0.88.1-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Fedora Update System 2024-02-15 21:10:21 UTC
FEDORA-2024-38be604d6c (rust-nu-command-0.88.1-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-38be604d6c

Comment 8 Fedora Update System 2024-02-15 21:12:28 UTC
FEDORA-2024-38be604d6c (rust-nu-command-0.88.1-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.