Bug 2211427 (review-rust-titlecase) - Review Request: rust-titlecase - Capitalize text according to the Daring Fireball style
Summary: Review Request: rust-titlecase - Capitalize text according to the Daring Fire...
Keywords:
Status: CLOSED ERRATA
Alias: review-rust-titlecase
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: itp-rust-nu-command 2263954
TreeView+ depends on / blocked
 
Reported: 2023-05-31 15:22 UTC by Michel Lind
Modified: 2024-02-13 01:45 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-02-13 01:45:05 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Michel Lind 2023-05-31 15:22:31 UTC
Spec URL: https://salimma.fedorapeople.org/rust-titlecase.spec
SRPM URL: https://salimma.fedorapeople.org/rust-titlecase-2.2.1-1.fc39.src.rpm

Description:
A tool and library that capitalizes text according to a style defined by
John Gruber for post titles on his website Daring Fireball.

Fedora Account System Username: salimma

Comment 1 Fabio Valentini 2023-06-06 19:52:03 UTC
> [dependencies.joinery]
> version = "< 3.0"

This is very weird, please confirm that this is intended ...
It also currently prevents the package from building, so either this needs to be relaxed, or you need to build the joinery v2 compat package which has already been approved / created / imported here: https://bugzilla.redhat.com/show_bug.cgi?id=2174100 ...

Comment 2 Fabio Valentini 2023-06-06 19:52:28 UTC
Also, the generated Summary is much too long, please trim.

Comment 3 Michel Lind 2023-06-08 18:39:57 UTC
(In reply to Fabio Valentini from comment #1)
> > [dependencies.joinery]
> > version = "< 3.0"
> 
> This is very weird, please confirm that this is intended ...
> It also currently prevents the package from building, so either this needs
> to be relaxed, or you need to build the joinery v2 compat package which has
> already been approved / created / imported here:
> https://bugzilla.redhat.com/show_bug.cgi?id=2174100 ...

Ah yes. My previous joinery2 build got caught out by some s390x outage, let me get that out and also figure out if this package really needs it

Comment 4 Package Review 2024-01-04 00:45:41 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.

Comment 5 Michel Lind 2024-02-12 21:39:22 UTC
Reopening, this is needed by nu-command. Checking the joinery < 3 issue, but joinery 2.x is in Fedora now anyway

Comment 7 Fabio Valentini 2024-02-12 22:18:19 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 8 Fedora Admin user for bugzilla script actions 2024-02-13 01:33:13 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-titlecase

Comment 9 Fedora Update System 2024-02-13 01:41:58 UTC
FEDORA-2024-1f3fabb4c9 (rust-titlecase-2.2.1-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-1f3fabb4c9

Comment 10 Fedora Update System 2024-02-13 01:45:05 UTC
FEDORA-2024-1f3fabb4c9 (rust-titlecase-2.2.1-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.