Bug 226422
| Summary: | Merge Review: slrn | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nobody's working on this, feel free to take it <nobody> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mcepl, mcepl, mlichvar, ppisar |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-01-31 12:34:26 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Nobody's working on this, feel free to take it
2007-01-31 20:59:55 UTC
1)good to have requires for -pull in following format
- MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release}
rest packaging looks ok.
Ok, slrn-pull-0.9.8.1pl1-6.20070716cvs.fc9 has %{version}-%{release} in the
requirement.
Packaging looks ok now. rpmlint gave me slrn.i386: W: file-not-utf8 /usr/share/doc/slrn-0.9.8.1pl1/changes.txt The character encoding of this file is not UTF-8. Consider converting it in the specfile for example using iconv(1). ==> This must be fixed. You can do this in next release. slrn-pull.i386: E: non-standard-dir-perm /var/spool/slrnpull 0775 A standard directory should have permission set to 0755. If you get this message, it means that you have wrong directory permissions in some dirs included in your package. slrn-pull.i386: E: incoherent-logrotate-file /etc/logrotate.d/slrnpull Your logrotate file should be named /etc/logrotate.d/<package name>. slrn-pull.i386: E: setgid-binary /usr/bin/slrnpull news 02750 The file is setgid. Usually this is a packaging bug. If this is a game, then, you should use the proper rpm group, or location. slrn-pull.i386: E: non-standard-executable-perm /usr/bin/slrnpull 02750 A standard executable should have permission set to 0755. If you get this message, it means that you have a wrong executable permissions in some files included in your package. slrn-pull.i386: E: non-standard-executable-perm /usr/bin/slrnpull 02750 A standard executable should have permission set to 0755. If you get this message, it means that you have a wrong executable permissions in some files included in your package. slrn-pull.i386: E: non-standard-dir-perm /var/spool/slrnpull/out.going 03777 A standard directory should have permission set to 0755. If you get this message, it means that you have wrong directory permissions in some dirs included in your package. ==> are those needed for this package? ping? Ok, converting the changelog and renaming the logrotate file is easy. As for the permissions, I'm not really sure. - /var/spool/slrnpull needs to be writable by news group. - /usr/bin/slrnpull doesn't seem to need the setgid (it's supposed to be executed under user news). 755 should be enough and it will also allow users to run slrnpull. - /var/spool/slrnpull/out.going needs to be writable by users allowed to post articles which is now everyone. The directory needs to have setgid news to allow slrnpull to remove the files. Suggestions? (In reply to comment #5) > Ok, converting the changelog and renaming the logrotate file is easy. Ok. > > As for the permissions, I'm not really sure. > > - /var/spool/slrnpull needs to be writable by news group. Good to keep it then. > > - /usr/bin/slrnpull doesn't seem to need the setgid (it's supposed to be > executed under user news). 755 should be enough and it will also allow users to > run slrnpull. I leave this upto you. > > - /var/spool/slrnpull/out.going needs to be writable by users allowed to post > articles which is now everyone. The directory needs to have setgid news to allow > slrnpull to remove the files. Good to keep it then. When you update CVS, do comment here for review. Committed to CVS. Thanks for update. Now rpmlint only have message slrn-pull.i386: E: non-standard-dir-perm /var/spool/slrnpull 0775 slrn-pull.i386: E: non-standard-dir-perm /var/spool/slrnpull/out.going 03777 MUST: Sorry. I missed this => Source URL should be http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.bz2 Look more on it at http://fedoraproject.org/wiki/Packaging/SourceURL Source URL fixed. thanks for CVS update. APPROVED. *** Bug 1160081 has been marked as a duplicate of this bug. *** Matej, I'm not interested in epel7. If you want the package there feel free to request for the branch for yourself and to maintain it. (In reply to Petr Pisar from comment #12) > Matej, I'm not interested in epel7. If you want the package there feel free > to request for the branch for yourself and to maintain it. Most gladly Package Change Request ====================== Package Name: slrn New Branches: epel7 Owners: mcepl Git done (by process-git-requests). |