Bug 226422 - Merge Review: slrn
Merge Review: slrn
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Package Reviews List
:
: 1160081 (view as bug list)
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 15:59 EST by Nobody's working on this, feel free to take it
Modified: 2014-11-05 06:35 EST (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-01-31 07:34:26 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+
limburgher: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 15:59:55 EST
Fedora Merge Review: slrn

http://cvs.fedora.redhat.com/viewcvs/devel/slrn/
Initial Owner: mlichvar@redhat.com
Comment 1 Parag AN(पराग) 2008-01-15 07:34:20 EST
1)good to have requires for -pull in following format
- MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release} 

rest packaging looks ok.
Comment 2 Miroslav Lichvar 2008-01-15 11:58:39 EST
Ok, slrn-pull-0.9.8.1pl1-6.20070716cvs.fc9 has %{version}-%{release} in the
requirement.
Comment 3 Parag AN(पराग) 2008-01-15 23:02:09 EST
Packaging looks ok now.
rpmlint gave me
slrn.i386: W: file-not-utf8 /usr/share/doc/slrn-0.9.8.1pl1/changes.txt
The character encoding of this file is not UTF-8.  Consider converting it
in the specfile for example using iconv(1).
==> This must be fixed. You can do this in next release.

slrn-pull.i386: E: non-standard-dir-perm /var/spool/slrnpull 0775
A standard directory should have permission set to 0755. If you get this
message, it means that you have wrong directory permissions in some dirs
included in your package.

slrn-pull.i386: E: incoherent-logrotate-file /etc/logrotate.d/slrnpull
Your logrotate file should be named /etc/logrotate.d/<package name>.

slrn-pull.i386: E: setgid-binary /usr/bin/slrnpull news 02750
The file is setgid. Usually this is a packaging bug. If this is a game, 
then, you should use the proper rpm group, or location.

slrn-pull.i386: E: non-standard-executable-perm /usr/bin/slrnpull 02750
A standard executable should have permission set to 0755. If you get this
message, it means that you have a wrong executable permissions in some files
included in your package.

slrn-pull.i386: E: non-standard-executable-perm /usr/bin/slrnpull 02750
A standard executable should have permission set to 0755. If you get this
message, it means that you have a wrong executable permissions in some files
included in your package.

slrn-pull.i386: E: non-standard-dir-perm /var/spool/slrnpull/out.going 03777
A standard directory should have permission set to 0755. If you get this
message, it means that you have wrong directory permissions in some dirs
included in your package.

==> are those needed for this package?
Comment 4 Parag AN(पराग) 2008-01-27 09:32:04 EST
ping?
Comment 5 Miroslav Lichvar 2008-01-28 10:28:55 EST
Ok, converting the changelog and renaming the logrotate file is easy.

As for the permissions, I'm not really sure.

- /var/spool/slrnpull needs to be writable by news group.

- /usr/bin/slrnpull doesn't seem to need the setgid (it's supposed to be
executed under user news). 755 should be enough and it will also allow users to
run slrnpull.

- /var/spool/slrnpull/out.going needs to be writable by users allowed to post
articles which is now everyone. The directory needs to have setgid news to allow
slrnpull to remove the files.

Suggestions?
Comment 6 Parag AN(पराग) 2008-01-29 07:27:14 EST
(In reply to comment #5)
> Ok, converting the changelog and renaming the logrotate file is easy.
 Ok.

> 
> As for the permissions, I'm not really sure.
> 
> - /var/spool/slrnpull needs to be writable by news group.
  Good to keep it then.

> 
> - /usr/bin/slrnpull doesn't seem to need the setgid (it's supposed to be
> executed under user news). 755 should be enough and it will also allow users to
> run slrnpull.

  I leave this upto you. 

> 
> - /var/spool/slrnpull/out.going needs to be writable by users allowed to post
> articles which is now everyone. The directory needs to have setgid news to allow
> slrnpull to remove the files.
  Good to keep it then.

When you update CVS, do comment here for review.
Comment 7 Miroslav Lichvar 2008-01-30 09:12:25 EST
Committed to CVS.
Comment 8 Parag AN(पराग) 2008-01-30 23:30:09 EST
Thanks for update.
Now rpmlint only have message
slrn-pull.i386: E: non-standard-dir-perm /var/spool/slrnpull 0775
slrn-pull.i386: E: non-standard-dir-perm /var/spool/slrnpull/out.going 03777

MUST:
   Sorry. I missed this => Source URL should be
http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.bz2
Look more on it at http://fedoraproject.org/wiki/Packaging/SourceURL

Comment 9 Miroslav Lichvar 2008-01-31 06:38:40 EST
Source URL fixed.
Comment 10 Parag AN(पराग) 2008-01-31 07:31:44 EST
thanks for CVS update.

APPROVED.
Comment 11 Petr Pisar 2014-11-04 02:18:00 EST
*** Bug 1160081 has been marked as a duplicate of this bug. ***
Comment 12 Petr Pisar 2014-11-04 02:19:11 EST
Matej, I'm not interested in epel7. If you want the package there feel free to request for the branch for yourself and to maintain it.
Comment 13 Matěj Cepl 2014-11-04 04:16:34 EST
(In reply to Petr Pisar from comment #12)
> Matej, I'm not interested in epel7. If you want the package there feel free
> to request for the branch for yourself and to maintain it.

Most gladly

Package Change Request
======================
Package Name: slrn
New Branches: epel7
Owners: mcepl
Comment 14 Jon Ciesla 2014-11-05 06:35:33 EST
Git done (by process-git-requests).

Note You need to log in before you can comment on or make changes to this bug.