Bug 2264493

Summary: Review Request: rust-nu - New type of shell
Product: [Fedora] Fedora Reporter: Michel Lind <michel>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Flags: decathorpe: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://crates.io/crates/nu
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-02-17 05:02:43 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2264484, 2264490    
Bug Blocks:    

Description Michel Lind 2024-02-16 00:52:25 UTC
Spec URL: https://salimma.fedorapeople.org/specs/rust-nu.spec
SRPM URL: https://salimma.fedorapeople.org/specs/rust-nu-0.88.1-1.fc39.src.rpm

Description:
A new type of shell.

Fedora Account System Username: salimma

Comment 1 Fedora Review Service 2024-02-16 00:54:51 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7021343
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2264493-rust-nu/fedora-rawhide-x86_64/07021343-rust-nu/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2024-02-16 20:10:29 UTC
Local test build was performed against the results of the other pending (but already approved) packages.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
o test suite is run and all unit tests pass (some tests skipped with explanation)
o latest version of the crate is packaged (version matches the version of other nu-* crates that are already packaged in Fedora)
- license matches upstream specification and is acceptable for Fedora
- licenses of statically linked dependencies are correctly taken into account
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

Please remove this line from the %files list, we don't build wix installers, so this file is irrelevant (it's also only a rich-text formatted version of the MIT license text, so it's also redundant):

> %license wix/License.rtf

PS: Would it make sense to request a nushell equivalent of %bash_completions_dir / %fish_completions_dir to be added to the filesystem package? That would allow packages to install nushell completions without needing to co-own the completions directory.

PPS: Congratulations on getting nushell packaged 🎉

Comment 3 Fedora Admin user for bugzilla script actions 2024-02-16 21:40:59 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-nu

Comment 4 Fedora Update System 2024-02-17 05:01:34 UTC
FEDORA-2024-b8f6a10ae2 (rust-nu-0.88.1-2.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-b8f6a10ae2

Comment 5 Fedora Update System 2024-02-17 05:02:43 UTC
FEDORA-2024-b8f6a10ae2 (rust-nu-0.88.1-2.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 6 Fedora Update System 2024-02-17 13:08:17 UTC
FEDORA-2024-3dd83d798c (rust-lsp-server-0.7.5-1.fc39, rust-nu-0.88.1-2.fc39, and 4 more) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-3dd83d798c

Comment 7 Fedora Update System 2024-02-17 19:17:02 UTC
FEDORA-2024-0371259078 (rust-lsp-server-0.7.5-1.fc38, rust-nu-0.88.1-2.fc38, and 4 more) has been submitted as an update to Fedora 38.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-0371259078

Comment 8 Fedora Update System 2024-02-18 01:49:04 UTC
FEDORA-2024-3dd83d798c has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-3dd83d798c \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-3dd83d798c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2024-02-18 02:32:52 UTC
FEDORA-2024-0371259078 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-0371259078 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-0371259078

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2024-02-19 02:29:02 UTC
FEDORA-2024-3dd83d798c (rust-lsp-server-0.7.5-1.fc39, rust-nu-0.88.1-2.fc39, and 4 more) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2024-02-19 03:17:39 UTC
FEDORA-2024-0371259078 (rust-lsp-server-0.7.5-1.fc38, rust-nu-0.88.1-2.fc38, and 4 more) has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2024-02-20 06:03:53 UTC
FEDORA-EPEL-2024-c982991ce8 (rust-ansi-str-0.8.0-1.el9, rust-arrayref-0.3.7-2.el9, and 73 more) has been submitted as an update to Fedora EPEL 9.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-c982991ce8

Comment 13 Fedora Update System 2024-02-21 00:52:52 UTC
FEDORA-EPEL-2024-c982991ce8 (rust-ansi-str-0.8.0-1.el9, rust-arrayref-0.3.7-2.el9, and 75 more) has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.