Bug 2264484 - Review Request: rust-nu-cli - CLI-related functionality for Nushell
Summary: Review Request: rust-nu-cli - CLI-related functionality for Nushell
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/nu-cli
Whiteboard:
Depends On:
Blocks: 2264493
TreeView+ depends on / blocked
 
Reported: 2024-02-15 23:49 UTC by Michel Lind
Modified: 2024-02-17 03:11 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-02-17 03:11:43 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Michel Lind 2024-02-15 23:49:31 UTC
Spec URL: https://salimma.fedorapeople.org/specs/rust-nu-cli.spec
SRPM URL: https://salimma.fedorapeople.org/specs/rust-nu-cli-0.88.1-1.fc39.src.rpm

Description:
CLI-related functionality for Nushell.

Fedora Account System Username: salimma

Comment 1 Fedora Review Service 2024-02-15 23:51:47 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7021213
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2264484-rust-nu-cli/fedora-rawhide-x86_64/07021213-rust-nu-cli/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2024-02-16 19:12:40 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass (some tests disabled with explanation)
! latest version of the crate is packaged (matches version of other nu-* crates already in Fedora though)
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 3 Fedora Admin user for bugzilla script actions 2024-02-16 21:39:28 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-nu-cli

Comment 4 Fedora Update System 2024-02-17 03:10:52 UTC
FEDORA-2024-c8e719cff9 (rust-nu-cli-0.88.1-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-c8e719cff9

Comment 5 Fedora Update System 2024-02-17 03:11:43 UTC
FEDORA-2024-c8e719cff9 (rust-nu-cli-0.88.1-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.