Bug 226506
Summary: | Merge Review: ttmkfdir | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Nobody's working on this, feel free to take it <nobody> |
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | i18n-bugs, panemade, psatpute |
Target Milestone: | --- | Flags: | panemade:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-12-17 06:54:41 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Nobody's working on this, feel free to take it
2007-01-31 21:12:42 UTC
updated spec file url: http://pravins.fedorapeople.org/ttmkfdir/ttmkfdir.spec srpm url: http://pravins.fedorapeople.org/ttmkfdir/ttmkfdir-3.0.9-27.fc9.src.rpm requested by Jens Petersen (#27995) will review this. Assigning review to me for now. 1) Buildroot should be from http://fedoraproject.org/wiki/PackagingGuidelines#BuildRoot_tag 2) defattr usage should be %defattr(-,root,root, -) 3) according to http://fedoraproject.org/wiki/PackagingGuidelines#Why_the_.25makeinstall_macro_should_not_be_used use make DESTDIR=$RPM_BUILD_ROOT install 4) Also, in Changelog use %%post instead of %post modified as per comments updated spec file http://pravins.fedorapeople.org/ttmkfdir/ttmkfdir.spec updated srpm http://pravins.fedorapeople.org/ttmkfdir/ttmkfdir-3.0.9-28.fc10.src.rpm rpmlint on srpm gives ttmkfdir.src: W: no-url-tag updated spec file http://pravins.fedorapeople.org/ttmkfdir/ttmkfdir.spec updated srpm http://pravins.fedorapeople.org/ttmkfdir/ttmkfdir-3.0.9-28.fc10.src.rpm package built successfully http://koji.fedoraproject.org/koji/taskinfo?taskID=999153 rpmlint only complained ttmkfdir.src: W: no-url-tag But I see that there is already comment as per http://fedoraproject.org/wiki/Packaging/SourceURL#We_are_Upstream Can you build this package in rawhide now? Once its built I will approve review. Done built it for rawhide http://koji.fedoraproject.org/koji/taskinfo?taskID=999184 Thanks for completing merge review of ttmkfdir Thanks for building package. APPROVED This Merge-Review. |