Red Hat Bugzilla – Bug 226506
Merge Review: ttmkfdir
Last modified: 2008-12-17 01:54:41 EST
Fedora Merge Review: ttmkfdir http://cvs.fedora.redhat.com/viewcvs/devel/ttmkfdir/ Initial Owner: lizhang@redhat.com
updated spec file url: http://pravins.fedorapeople.org/ttmkfdir/ttmkfdir.spec srpm url: http://pravins.fedorapeople.org/ttmkfdir/ttmkfdir-3.0.9-27.fc9.src.rpm
requested by Jens Petersen (#27995)
will review this. Assigning review to me for now.
1) Buildroot should be from http://fedoraproject.org/wiki/PackagingGuidelines#BuildRoot_tag 2) defattr usage should be %defattr(-,root,root, -) 3) according to http://fedoraproject.org/wiki/PackagingGuidelines#Why_the_.25makeinstall_macro_should_not_be_used use make DESTDIR=$RPM_BUILD_ROOT install 4) Also, in Changelog use %%post instead of %post
modified as per comments updated spec file http://pravins.fedorapeople.org/ttmkfdir/ttmkfdir.spec updated srpm http://pravins.fedorapeople.org/ttmkfdir/ttmkfdir-3.0.9-28.fc10.src.rpm rpmlint on srpm gives ttmkfdir.src: W: no-url-tag
updated spec file http://pravins.fedorapeople.org/ttmkfdir/ttmkfdir.spec updated srpm http://pravins.fedorapeople.org/ttmkfdir/ttmkfdir-3.0.9-28.fc10.src.rpm
package built successfully http://koji.fedoraproject.org/koji/taskinfo?taskID=999153 rpmlint only complained ttmkfdir.src: W: no-url-tag But I see that there is already comment as per http://fedoraproject.org/wiki/Packaging/SourceURL#We_are_Upstream Can you build this package in rawhide now? Once its built I will approve review.
Done built it for rawhide http://koji.fedoraproject.org/koji/taskinfo?taskID=999184 Thanks for completing merge review of ttmkfdir
Thanks for building package. APPROVED This Merge-Review.