Bug 226506 - Merge Review: ttmkfdir
Summary: Merge Review: ttmkfdir
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-01-31 21:12 UTC by Nobody's working on this, feel free to take it
Modified: 2008-12-17 06:54 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-12-17 06:54:41 UTC
Type: ---
panemade: fedora-review+


Attachments (Terms of Use)

Description Nobody's working on this, feel free to take it 2007-01-31 21:12:42 UTC
Fedora Merge Review: ttmkfdir

http://cvs.fedora.redhat.com/viewcvs/devel/ttmkfdir/
Initial Owner: lizhang@redhat.com

Comment 2 Tony Fu 2008-09-10 03:07:14 UTC
requested by Jens Petersen (#27995)

Comment 3 Parag AN(पराग) 2008-12-12 08:49:52 UTC
will review this. Assigning review to me for now.

Comment 4 Parag AN(पराग) 2008-12-15 05:38:31 UTC
1) Buildroot should be from http://fedoraproject.org/wiki/PackagingGuidelines#BuildRoot_tag

2) defattr usage should be %defattr(-,root,root, -)

3) according to 
http://fedoraproject.org/wiki/PackagingGuidelines#Why_the_.25makeinstall_macro_should_not_be_used
use make DESTDIR=$RPM_BUILD_ROOT install

4) Also, in Changelog use %%post instead of %post

Comment 5 Pravin Satpute 2008-12-15 10:39:05 UTC
modified as per comments
updated spec file
http://pravins.fedorapeople.org/ttmkfdir/ttmkfdir.spec

updated srpm 
http://pravins.fedorapeople.org/ttmkfdir/ttmkfdir-3.0.9-28.fc10.src.rpm

rpmlint on srpm gives
ttmkfdir.src: W: no-url-tag

Comment 7 Parag AN(पराग) 2008-12-15 11:16:50 UTC
package built successfully http://koji.fedoraproject.org/koji/taskinfo?taskID=999153

rpmlint only complained 
ttmkfdir.src: W: no-url-tag
But I see that there is already comment as per http://fedoraproject.org/wiki/Packaging/SourceURL#We_are_Upstream

Can you build this package in rawhide now? Once its built I will approve review.

Comment 8 Pravin Satpute 2008-12-15 11:39:57 UTC
Done
built it for rawhide
http://koji.fedoraproject.org/koji/taskinfo?taskID=999184

Thanks for completing merge review of ttmkfdir

Comment 9 Parag AN(पराग) 2008-12-15 13:14:33 UTC
Thanks for building package.

APPROVED This Merge-Review.


Note You need to log in before you can comment on or make changes to this bug.