This service will be undergoing maintenance at 00:00 UTC, 2016-09-28. It is expected to last about 1 hours
Bug 226506 - Merge Review: ttmkfdir
Merge Review: ttmkfdir
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 16:12 EST by Nobody's working on this, feel free to take it
Modified: 2008-12-17 01:54 EST (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-12-17 01:54:41 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
panemade: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 16:12:42 EST
Fedora Merge Review: ttmkfdir

http://cvs.fedora.redhat.com/viewcvs/devel/ttmkfdir/
Initial Owner: lizhang@redhat.com
Comment 2 Tony Fu 2008-09-09 23:07:14 EDT
requested by Jens Petersen (#27995)
Comment 3 Parag AN(पराग) 2008-12-12 03:49:52 EST
will review this. Assigning review to me for now.
Comment 4 Parag AN(पराग) 2008-12-15 00:38:31 EST
1) Buildroot should be from http://fedoraproject.org/wiki/PackagingGuidelines#BuildRoot_tag

2) defattr usage should be %defattr(-,root,root, -)

3) according to 
http://fedoraproject.org/wiki/PackagingGuidelines#Why_the_.25makeinstall_macro_should_not_be_used
use make DESTDIR=$RPM_BUILD_ROOT install

4) Also, in Changelog use %%post instead of %post
Comment 5 Pravin Satpute 2008-12-15 05:39:05 EST
modified as per comments
updated spec file
http://pravins.fedorapeople.org/ttmkfdir/ttmkfdir.spec

updated srpm 
http://pravins.fedorapeople.org/ttmkfdir/ttmkfdir-3.0.9-28.fc10.src.rpm

rpmlint on srpm gives
ttmkfdir.src: W: no-url-tag
Comment 7 Parag AN(पराग) 2008-12-15 06:16:50 EST
package built successfully http://koji.fedoraproject.org/koji/taskinfo?taskID=999153

rpmlint only complained 
ttmkfdir.src: W: no-url-tag
But I see that there is already comment as per http://fedoraproject.org/wiki/Packaging/SourceURL#We_are_Upstream

Can you build this package in rawhide now? Once its built I will approve review.
Comment 8 Pravin Satpute 2008-12-15 06:39:57 EST
Done
built it for rawhide
http://koji.fedoraproject.org/koji/taskinfo?taskID=999184

Thanks for completing merge review of ttmkfdir
Comment 9 Parag AN(पराग) 2008-12-15 08:14:33 EST
Thanks for building package.

APPROVED This Merge-Review.

Note You need to log in before you can comment on or make changes to this bug.