Bug 2265191
| Summary: | Review Request: qt6-qtopcua - Qt OPC UA (API) provides classes and functions to access the OPC UA protocol | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | loise <loise> |
| Component: | Package Review | Assignee: | Jan Grulich <jgrulich> |
| Status: | POST --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jgrulich, package-review |
| Target Milestone: | --- | Flags: | jgrulich:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://www.qt.io | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | --- | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
loise@kde.org
2024-02-20 20:27:25 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/7040351 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2265191-qt6-qtopcua/fedora-rawhide-x86_64/07040351-qt6-qtopcua/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Looks good to me. Just minor issues that can be fixed during import.
Naming: OK
Licenses: OK
Dependencies: OK
Minor issues:
1) Both %{_qt6_libdir}/cmake/Qt6 and %dir %{_qt6_libdir}/cmake/Qt6Qml/QmlPlugins/ are not owned by this package.
2) #libQt6Core.so.6(Qt_5_PRIVATE_API)(64bit) → It's just a comment, but mentions Qt5
3) in -devel, I think "Requires: qt6-qtbase-devel%{?_isa}" is not necessary, it will get pulled through the deps anyway.
The Pagure repository was created at https://src.fedoraproject.org/rpms/qt6-qtopcua |