Bug 2265191 - Review Request: qt6-qtopcua - Qt OPC UA (API) provides classes and functions to access the OPC UA protocol
Summary: Review Request: qt6-qtopcua - Qt OPC UA (API) provides classes and functions ...
Keywords:
Status: POST
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jan Grulich
QA Contact: Fedora Extras Quality Assurance
URL: http://www.qt.io
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-02-20 20:27 UTC by loise@kde.org
Modified: 2024-02-22 14:42 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
jgrulich: fedora-review+


Attachments (Terms of Use)

Comment 1 Fedora Review Service 2024-02-20 20:36:45 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7040351
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2265191-qt6-qtopcua/fedora-rawhide-x86_64/07040351-qt6-qtopcua/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Jan Grulich 2024-02-22 10:20:33 UTC
Looks good to me. Just minor issues that can be fixed during import.

Naming: OK
Licenses: OK
Dependencies: OK

Minor issues:
1) Both  %{_qt6_libdir}/cmake/Qt6 and %dir %{_qt6_libdir}/cmake/Qt6Qml/QmlPlugins/ are not owned by this package.
2) #libQt6Core.so.6(Qt_5_PRIVATE_API)(64bit) → It's just a comment, but mentions Qt5
3) in -devel, I think "Requires: qt6-qtbase-devel%{?_isa}" is not necessary, it will get pulled through the deps anyway.

Comment 3 Fedora Admin user for bugzilla script actions 2024-02-22 14:42:35 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/qt6-qtopcua


Note You need to log in before you can comment on or make changes to this bug.