Bug 226528

Summary:	Merge Review: virt-manager
Product:	[Fedora] Fedora	Reporter:	Nobody's working on this, feel free to take it <nobody>
Component:	Package Review	Assignee:	David Lutterkort <lutter>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	berrange, crobinso, hbrock, markmc
Target Milestone:	---	Flags:	lutter: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-01-23 19:50:44 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Nobody's working on this, feel free to take it 2007-01-31 21:15:26 UTC

Fedora Merge Review: virt-manager

http://cvs.fedora.redhat.com/viewcvs/devel/virt-manager/
Initial Owner: berrange

Comment 1 David Lutterkort 2007-05-03 22:03:20 UTC

Review is based on
http://koji.fedoraproject.org/packages/virt-manager/0.4.0/1.fc7/src/virt-manager-0.4.0-1.fc7.src.rpm

Overall, specfile looks good, conforms with packaging guidelines

rpmlint reports:

  W: virt-manager non-conffile-in-etc /etc/security/console.apps/virt-manager
  W: virt-manager non-conffile-in-etc /etc/gconf/schemas/virt-manager.schemas
  W: virt-manager non-conffile-in-etc /etc/pam.d/virt-manager

The pam.d file should be marked as %config(noreplace); the others seem ok

  W: virt-manager symlink-should-be-relative /usr/bin/virt-manager
/usr/bin/consolehelper

Easy fix

  E: virt-manager explicit-lib-dependency librsvg2

It seems that that is ok; AFAICT, rpm won't be able to find this dependency.

Comment 2 David Lutterkort 2007-05-03 22:06:02 UTC

Please make the two little changes mentioned above. With that
APPROVED

Don't forget to mark CLOSED RAWHIDE when the changed specfile has been committed.

Comment 3 David Lutterkort 2008-01-10 23:34:47 UTC

Cole, could you take care of the above spec changes so we can get the review
finished ?

Comment 4 Daniel Berrangé 2008-01-11 02:06:41 UTC

These fixes will be in the new rawhide build virt-manager-0_5_3-1_fc9

Comment 5 Mark McLoughlin 2009-01-23 19:50:44 UTC

Okay, fixes were:

-ln -s %{_bindir}/consolehelper $RPM_BUILD_ROOT%{_bindir}/%{name}
+ln -s ../bin/consolehelper $RPM_BUILD_ROOT%{_bindir}/%{name}

-%{_sysconfdir}/pam.d/%{name}
+%config(noreplace) %{_sysconfdir}/pam.d/%{name}

Closing