Bug 226528 - Merge Review: virt-manager
Merge Review: virt-manager
Status: CLOSED CURRENTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: David Lutterkort
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 16:15 EST by Nobody's working on this, feel free to take it
Modified: 2013-04-30 19:40 EDT (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-01-23 14:50:44 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
lutter: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 16:15:26 EST
Fedora Merge Review: virt-manager

http://cvs.fedora.redhat.com/viewcvs/devel/virt-manager/
Initial Owner: berrange@redhat.com
Comment 1 David Lutterkort 2007-05-03 18:03:20 EDT
Review is based on
http://koji.fedoraproject.org/packages/virt-manager/0.4.0/1.fc7/src/virt-manager-0.4.0-1.fc7.src.rpm

Overall, specfile looks good, conforms with packaging guidelines

rpmlint reports:

  W: virt-manager non-conffile-in-etc /etc/security/console.apps/virt-manager
  W: virt-manager non-conffile-in-etc /etc/gconf/schemas/virt-manager.schemas
  W: virt-manager non-conffile-in-etc /etc/pam.d/virt-manager

The pam.d file should be marked as %config(noreplace); the others seem ok

  W: virt-manager symlink-should-be-relative /usr/bin/virt-manager
/usr/bin/consolehelper

Easy fix

  E: virt-manager explicit-lib-dependency librsvg2

It seems that that is ok; AFAICT, rpm won't be able to find this dependency.
Comment 2 David Lutterkort 2007-05-03 18:06:02 EDT
Please make the two little changes mentioned above. With that
APPROVED

Don't forget to mark CLOSED RAWHIDE when the changed specfile has been committed.
Comment 3 David Lutterkort 2008-01-10 18:34:47 EST
Cole, could you take care of the above spec changes so we can get the review
finished ?

Comment 4 Daniel Berrange 2008-01-10 21:06:41 EST
These fixes will be in the new rawhide build virt-manager-0_5_3-1_fc9
Comment 5 Mark McLoughlin 2009-01-23 14:50:44 EST
Okay, fixes were:

-ln -s %{_bindir}/consolehelper $RPM_BUILD_ROOT%{_bindir}/%{name}
+ln -s ../bin/consolehelper $RPM_BUILD_ROOT%{_bindir}/%{name}

-%{_sysconfdir}/pam.d/%{name}
+%config(noreplace) %{_sysconfdir}/pam.d/%{name}

Closing

Note You need to log in before you can comment on or make changes to this bug.