Fedora Merge Review: virt-manager http://cvs.fedora.redhat.com/viewcvs/devel/virt-manager/ Initial Owner: berrange
Review is based on http://koji.fedoraproject.org/packages/virt-manager/0.4.0/1.fc7/src/virt-manager-0.4.0-1.fc7.src.rpm Overall, specfile looks good, conforms with packaging guidelines rpmlint reports: W: virt-manager non-conffile-in-etc /etc/security/console.apps/virt-manager W: virt-manager non-conffile-in-etc /etc/gconf/schemas/virt-manager.schemas W: virt-manager non-conffile-in-etc /etc/pam.d/virt-manager The pam.d file should be marked as %config(noreplace); the others seem ok W: virt-manager symlink-should-be-relative /usr/bin/virt-manager /usr/bin/consolehelper Easy fix E: virt-manager explicit-lib-dependency librsvg2 It seems that that is ok; AFAICT, rpm won't be able to find this dependency.
Please make the two little changes mentioned above. With that APPROVED Don't forget to mark CLOSED RAWHIDE when the changed specfile has been committed.
Cole, could you take care of the above spec changes so we can get the review finished ?
These fixes will be in the new rawhide build virt-manager-0_5_3-1_fc9
Okay, fixes were: -ln -s %{_bindir}/consolehelper $RPM_BUILD_ROOT%{_bindir}/%{name} +ln -s ../bin/consolehelper $RPM_BUILD_ROOT%{_bindir}/%{name} -%{_sysconfdir}/pam.d/%{name} +%config(noreplace) %{_sysconfdir}/pam.d/%{name} Closing