Bug 2265663
| Summary: | Review Request: turbo-attack - A turbo traffic generator pentesting tool | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tim Semeijn <tim> | ||||
| Component: | Package Review | Assignee: | Mikel Olasagasti Uranga <mikel> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | mikel, package-review | ||||
| Target Milestone: | --- | Flags: | mikel:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2024-03-07 23:38:18 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Tim Semeijn
2024-02-23 14:25:49 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/7052946 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2265663-golang-github-mytechnotalent-turbo-attack/fedora-rawhide-x86_64/07052946-golang-github-mytechnotalent-turbo-attack/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://download.copr.fedorainfracloud.org/results/semeijn/lab/fedora-rawhide-x86_64/07053035-golang-github-mytechnotalent-turbo-attack/golang-github-mytechnotalent-turbo-attack.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/semeijn/lab/fedora-rawhide-x86_64/07053035-golang-github-mytechnotalent-turbo-attack/golang-github-mytechnotalent-turbo-attack-0.1.0-1.fc41.src.rpm Removed %{_bindir} wildcard in %files. Created attachment 2018328 [details]
The .spec file difference from Copr build 7052946 to 7053043
Copr build: https://copr.fedorainfracloud.org/coprs/build/7053043 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2265663-golang-github-mytechnotalent-turbo-attack/fedora-rawhide-x86_64/07053043-golang-github-mytechnotalent-turbo-attack/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. > Name: golang-github-mytechnotalent-turbo-attack What do you think about renaming it to turbo-attack? You can generate the spec with "go2rpm --name turbo-attack ...". You would need to rename the BZ title if you change the name. > Summary: A turbo traffic generator pentesting tool to generate random traffic with random mac and ip addresses in addition to random sequence numbers to a particular ip and port Too large > %gopkginstall > %gopkgfiles These generate the `golang-github-mytechnotalent-turbo-attack-devel` package that if not required by other packages it makes no sense to ship. Spec URL: https://semeijn.fedorapeople.org/review/turbo-attack.spec SRPM URL: https://semeijn.fedorapeople.org/review/turbo-attack-0.1.0-1.fc41.src.rpm > What do you think about renaming it to turbo-attack? You can generate the spec with "go2rpm --name turbo-attack ...". You would need to rename the BZ title if you change the name. Renamed! > Too large Fixed. > These generate the `golang-github-mytechnotalent-turbo-attack-devel` package that if not required by other packages it makes no sense to ship. No required by other packages so removed the devel package. Spec URL: https://semeijn.fedorapeople.org/review/turbo-attack.spec SRPM URL: https://semeijn.fedorapeople.org/review/turbo-attack-0.1.0-1.fc41.src.rpm > What do you think about renaming it to turbo-attack? You can generate the spec with "go2rpm --name turbo-attack ...". You would need to rename the BZ title if you change the name. Renamed! > Too large Fixed. > These generate the `golang-github-mytechnotalent-turbo-attack-devel` package that if not required by other packages it makes no sense to ship. No required by other packages so removed the devel package. Copr build: https://copr.fedorainfracloud.org/coprs/build/7112204 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2265663-turbo-attack/fedora-rawhide-x86_64/07112204-turbo-attack/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Copr build: https://copr.fedorainfracloud.org/coprs/build/7112205 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2265663-turbo-attack/fedora-rawhide-x86_64/07112205-turbo-attack/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. I am not going to go through the whole fedora-review template, as this package uses go2rpm. - [x] The specfile is sane. - [x] License is correct - [x] Builds successfully in mock - [x] Package is installable (checked by fedora-review) - [x] No relevant rpmlint errors - [x] %check section passes - [x] The latest version is packaged - [x] `%goipath` is set correctly - [x] Binaries don't conflict with binaries already in the distribution - [x] The package complies with the Packaging Guidelines. Package approved! On import, don't forget to do the following: - [ ] Add package to release-monitoring.org - [ ] Give go-sig privileges on package - [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket. Thanks for the review Mikel! The Pagure repository was created at https://src.fedoraproject.org/rpms/turbo-attack FEDORA-2024-6bfbce1aac (turbo-attack-0.1.0-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-6bfbce1aac FEDORA-2024-6bfbce1aac (turbo-attack-0.1.0-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. |