Bug 2265663 - Review Request: turbo-attack - A turbo traffic generator pentesting tool
Summary: Review Request: turbo-attack - A turbo traffic generator pentesting tool
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mikel Olasagasti Uranga
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-02-23 14:25 UTC by Tim Semeijn
Modified: 2024-03-07 23:38 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-03-07 23:38:18 UTC
Type: ---
Embargoed:
mikel: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 7052946 to 7053043 (232 bytes, patch)
2024-02-23 16:11 UTC, Fedora Review Service
no flags Details | Diff

Description Tim Semeijn 2024-02-23 14:25:49 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/semeijn/lab/fedora-rawhide-x86_64/07052928-golang-github-mytechnotalent-turbo-attack/golang-github-mytechnotalent-turbo-attack.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/semeijn/lab/fedora-rawhide-x86_64/07052928-golang-github-mytechnotalent-turbo-attack/golang-github-mytechnotalent-turbo-attack-0.1.0-1.fc41.src.rpm
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=113937547

Description:
A turbo traffic generator pentesting tool to generate random traffic with random mac and ip addresses in addition to random sequence numbers to a particular ip and port.

Fedora Account System Username: semeijn

Comment 1 Fedora Review Service 2024-02-23 14:29:54 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7052946
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2265663-golang-github-mytechnotalent-turbo-attack/fedora-rawhide-x86_64/07052946-golang-github-mytechnotalent-turbo-attack/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fedora Review Service 2024-02-23 16:11:40 UTC
Created attachment 2018328 [details]
The .spec file difference from Copr build 7052946 to 7053043

Comment 4 Fedora Review Service 2024-02-23 16:11:42 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7053043
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2265663-golang-github-mytechnotalent-turbo-attack/fedora-rawhide-x86_64/07053043-golang-github-mytechnotalent-turbo-attack/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Mikel Olasagasti Uranga 2024-03-06 10:43:42 UTC
> Name:           golang-github-mytechnotalent-turbo-attack

What do you think about renaming it to turbo-attack? You can generate the spec with "go2rpm --name turbo-attack ...". You would need to rename the BZ title if you change the name.

> Summary:        A turbo traffic generator pentesting tool to generate random traffic with random mac and ip addresses in addition to random sequence numbers to a particular ip and port

Too large

> %gopkginstall
> %gopkgfiles

These generate the `golang-github-mytechnotalent-turbo-attack-devel` package that if not required by other packages it makes no sense to ship.

Comment 6 Tim Semeijn 2024-03-06 13:09:56 UTC
Spec URL: https://semeijn.fedorapeople.org/review/turbo-attack.spec
SRPM URL: https://semeijn.fedorapeople.org/review/turbo-attack-0.1.0-1.fc41.src.rpm

> What do you think about renaming it to turbo-attack? You can generate the spec with "go2rpm --name turbo-attack ...". You would need to rename the BZ title if you change the name.

Renamed!

> Too large

Fixed.

> These generate the `golang-github-mytechnotalent-turbo-attack-devel` package that if not required by other packages it makes no sense to ship.

No required by other packages so removed the devel package.

Comment 7 Tim Semeijn 2024-03-06 13:10:13 UTC
Spec URL: https://semeijn.fedorapeople.org/review/turbo-attack.spec
SRPM URL: https://semeijn.fedorapeople.org/review/turbo-attack-0.1.0-1.fc41.src.rpm

> What do you think about renaming it to turbo-attack? You can generate the spec with "go2rpm --name turbo-attack ...". You would need to rename the BZ title if you change the name.

Renamed!

> Too large

Fixed.

> These generate the `golang-github-mytechnotalent-turbo-attack-devel` package that if not required by other packages it makes no sense to ship.

No required by other packages so removed the devel package.

Comment 8 Fedora Review Service 2024-03-06 13:12:32 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7112204
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2265663-turbo-attack/fedora-rawhide-x86_64/07112204-turbo-attack/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 9 Fedora Review Service 2024-03-06 13:13:10 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7112205
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2265663-turbo-attack/fedora-rawhide-x86_64/07112205-turbo-attack/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 10 Mikel Olasagasti Uranga 2024-03-06 20:36:19 UTC
I am not going to go through the whole fedora-review template, as this package uses go2rpm.

- [x] The specfile is sane.
- [x] License is correct
- [x] Builds successfully in mock
- [x] Package is installable (checked by fedora-review)
- [x] No relevant rpmlint errors
- [x] %check section passes
- [x] The latest version is packaged
- [x] `%goipath` is set correctly
- [x] Binaries don't conflict with binaries already in the distribution
- [x] The package complies with the Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add package to release-monitoring.org
- [ ] Give go-sig privileges on package
- [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket.

Comment 11 Tim Semeijn 2024-03-07 23:11:00 UTC
Thanks for the review Mikel!

Comment 12 Fedora Admin user for bugzilla script actions 2024-03-07 23:14:16 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/turbo-attack

Comment 13 Fedora Update System 2024-03-07 23:33:42 UTC
FEDORA-2024-6bfbce1aac (turbo-attack-0.1.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-6bfbce1aac

Comment 14 Fedora Update System 2024-03-07 23:38:18 UTC
FEDORA-2024-6bfbce1aac (turbo-attack-0.1.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.