Bug 226646

Summary: Merge Review: xorg-x11-util-macros
Product: [Fedora] Fedora Reporter: Nobody's working on this, feel free to take it <nobody>
Component: Package ReviewAssignee: Parag AN(पराग) <panemade>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: ajax, panemade, peter.hutterer, redhat-bugzilla
Target Milestone: ---Flags: panemade: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-07-20 00:35:33 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
xorg-x11-util-macros-spec-cleanup.patch none

Description Nobody's working on this, feel free to take it 2007-01-31 21:33:55 UTC
Fedora Merge Review: xorg-x11-util-macros

http://cvs.fedora.redhat.com/viewcvs/devel/xorg-x11-util-macros/
Initial Owner: ajackson@redhat.com

Comment 1 Parag AN(पराग) 2010-07-19 14:37:01 UTC
1) rpmlint on SRPM and RPM reported 
xorg-x11-util-macros.src: W: spelling-error Summary(en_US) Autotools -> Auto tools, Auto-tools, Autopilots
xorg-x11-util-macros.src: W: spelling-error %description -l en_US autotools -> auto tools, auto-tools, autopilots
xorg-x11-util-macros.noarch: E: explicit-lib-dependency libtool
xorg-x11-util-macros.noarch: W: spelling-error Summary(en_US) Autotools -> Auto tools, Auto-tools, Autopilots
xorg-x11-util-macros.noarch: W: spelling-error %description -l en_US autotools -> auto tools, auto-tools, autopilots
xorg-x11-util-macros.noarch: W: devel-file-in-non-devel-package /usr/share/pkgconfig/xorg-macros.pc
2 packages and 0 specfiles checked; 1 errors, 5 warnings.

2) I will suggest this package to follow current packaging guidelines and
remove buildroot, %clean section and cleaning of build root in %install. But this is not blocker for this review.

3) But reviewguildlines also says
MUST: Each package must consistently use macros. [16]
so this package should use macros.

Comment 2 Parag AN(पराग) 2010-07-19 14:38:55 UTC
Created attachment 432910 [details]
xorg-x11-util-macros-spec-cleanup.patch

Can this patch be applied to devel branch by current package owner for this package?

Comment 3 Peter Hutterer 2010-07-20 00:35:33 UTC
(In reply to comment #2)
> Created an attachment (id=432910) [details]
> xorg-x11-util-macros-spec-cleanup.patch
> 
> Can this patch be applied to devel branch by current package owner for this
> package?    

done, thanks.

Comment 4 Parag AN(पराग) 2010-07-20 04:00:21 UTC
Hi Peter,
  This is merge package review, See https://fedoraproject.org/wiki/Merge_Reviews

Thanks for applying the patch. Package looks good now and following fedora packaging guidelines.

APPROVED this merge-review now for build xorg-x11-util-macros-1.10.0-2.fc14