Bug 226646 - Merge Review: xorg-x11-util-macros
Merge Review: xorg-x11-util-macros
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 16:33 EST by Nobody's working on this, feel free to take it
Modified: 2010-07-20 00:00 EDT (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2010-07-19 20:35:33 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+


Attachments (Terms of Use)
xorg-x11-util-macros-spec-cleanup.patch (990 bytes, patch)
2010-07-19 10:38 EDT, Parag AN(पराग)
no flags Details | Diff

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 16:33:55 EST
Fedora Merge Review: xorg-x11-util-macros

http://cvs.fedora.redhat.com/viewcvs/devel/xorg-x11-util-macros/
Initial Owner: ajackson@redhat.com
Comment 1 Parag AN(पराग) 2010-07-19 10:37:01 EDT
1) rpmlint on SRPM and RPM reported 
xorg-x11-util-macros.src: W: spelling-error Summary(en_US) Autotools -> Auto tools, Auto-tools, Autopilots
xorg-x11-util-macros.src: W: spelling-error %description -l en_US autotools -> auto tools, auto-tools, autopilots
xorg-x11-util-macros.noarch: E: explicit-lib-dependency libtool
xorg-x11-util-macros.noarch: W: spelling-error Summary(en_US) Autotools -> Auto tools, Auto-tools, Autopilots
xorg-x11-util-macros.noarch: W: spelling-error %description -l en_US autotools -> auto tools, auto-tools, autopilots
xorg-x11-util-macros.noarch: W: devel-file-in-non-devel-package /usr/share/pkgconfig/xorg-macros.pc
2 packages and 0 specfiles checked; 1 errors, 5 warnings.

2) I will suggest this package to follow current packaging guidelines and
remove buildroot, %clean section and cleaning of build root in %install. But this is not blocker for this review.

3) But reviewguildlines also says
MUST: Each package must consistently use macros. [16]
so this package should use macros.
Comment 2 Parag AN(पराग) 2010-07-19 10:38:55 EDT
Created attachment 432910 [details]
xorg-x11-util-macros-spec-cleanup.patch

Can this patch be applied to devel branch by current package owner for this package?
Comment 3 Peter Hutterer 2010-07-19 20:35:33 EDT
(In reply to comment #2)
> Created an attachment (id=432910) [details]
> xorg-x11-util-macros-spec-cleanup.patch
> 
> Can this patch be applied to devel branch by current package owner for this
> package?    

done, thanks.
Comment 4 Parag AN(पराग) 2010-07-20 00:00:21 EDT
Hi Peter,
  This is merge package review, See https://fedoraproject.org/wiki/Merge_Reviews

Thanks for applying the patch. Package looks good now and following fedora packaging guidelines.

APPROVED this merge-review now for build xorg-x11-util-macros-1.10.0-2.fc14

Note You need to log in before you can comment on or make changes to this bug.