Fedora Merge Review: xorg-x11-util-macros http://cvs.fedora.redhat.com/viewcvs/devel/xorg-x11-util-macros/ Initial Owner: ajackson
1) rpmlint on SRPM and RPM reported xorg-x11-util-macros.src: W: spelling-error Summary(en_US) Autotools -> Auto tools, Auto-tools, Autopilots xorg-x11-util-macros.src: W: spelling-error %description -l en_US autotools -> auto tools, auto-tools, autopilots xorg-x11-util-macros.noarch: E: explicit-lib-dependency libtool xorg-x11-util-macros.noarch: W: spelling-error Summary(en_US) Autotools -> Auto tools, Auto-tools, Autopilots xorg-x11-util-macros.noarch: W: spelling-error %description -l en_US autotools -> auto tools, auto-tools, autopilots xorg-x11-util-macros.noarch: W: devel-file-in-non-devel-package /usr/share/pkgconfig/xorg-macros.pc 2 packages and 0 specfiles checked; 1 errors, 5 warnings. 2) I will suggest this package to follow current packaging guidelines and remove buildroot, %clean section and cleaning of build root in %install. But this is not blocker for this review. 3) But reviewguildlines also says MUST: Each package must consistently use macros. [16] so this package should use macros.
Created attachment 432910 [details] xorg-x11-util-macros-spec-cleanup.patch Can this patch be applied to devel branch by current package owner for this package?
(In reply to comment #2) > Created an attachment (id=432910) [details] > xorg-x11-util-macros-spec-cleanup.patch > > Can this patch be applied to devel branch by current package owner for this > package? done, thanks.
Hi Peter, This is merge package review, See https://fedoraproject.org/wiki/Merge_Reviews Thanks for applying the patch. Package looks good now and following fedora packaging guidelines. APPROVED this merge-review now for build xorg-x11-util-macros-1.10.0-2.fc14