Bug 2266733

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7084399
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2266733-rust-circular-buffer/fedora-rawhide-x86_64/07084399-rust-circular-buffer/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

> # FIXME: no license files detected

It looks like you missed this?

(In reply to Fabio Valentini from comment #2)
> > # FIXME: no license files detected
> 
> It looks like you missed this?

Ouch! I’ll correct that and re-upload.

The upstream git repository at https://github.com/andreacorbellini/rust-circular-buffer has no license text at all, so I filed https://github.com/andreacorbellini/rust-circular-buffer/issues/14. I’d rather not guess at the correct text, as technically allowed in https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text, so I’m hoping upstream responds fairly promptly.

Once the license text issue is dealt with, I plan to generate the new submission with rust2rpm 26 and the following rust2rpm.toml:

[package]
cargo-toml-patch-comments = [
    "Drop dev dependency on the criterion crate, which is used only for benchmarks",
]
[features]
hide = [
    "unstable",
]

Upstream has included license text in a new 0.1.7 release: https://github.com/andreacorbellini/rust-circular-buffer/releases/tag/v0.1.7

New Spec URL: https://music.fedorapeople.org/20240318/rust-circular-buffer.spec
New SRPM URL: https://music.fedorapeople.org/20240318/rust-circular-buffer-0.1.7-1.fc39.src.rpm

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7179818
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2266733-rust-circular-buffer/fedora-rawhide-x86_64/07179818-rust-circular-buffer/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

(In reply to Fabio Valentini from comment #2)
> > # FIXME: no license files detected
> 
> It looks like you missed this?

No big hurry, but just a reminder that this is now reviewable.

Sorry for the delay, been working on time-critical stuff (GNOME+Rust stuff that is blocking the F40 release).

Package looks good now, thank you!

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Thanks!

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-circular-buffer

https://release-monitoring.org/project/371961/

FEDORA-2024-2b6fc623b0 (rust-circular-buffer-0.1.7-3.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-2b6fc623b0

FEDORA-2024-2b6fc623b0 (rust-circular-buffer-0.1.7-3.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2024-5ed72f1c81 (rust-circular-buffer-0.1.7-3.fc40 and rust-drop-tracker-0.1.3-2.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-5ed72f1c81

FEDORA-2024-267d66d22c (rust-circular-buffer-0.1.7-3.fc39 and rust-drop-tracker-0.1.3-2.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-267d66d22c

FEDORA-2024-c635a7ad05 (rust-circular-buffer-0.1.7-3.fc38 and rust-drop-tracker-0.1.3-2.fc38) has been submitted as an update to Fedora 38.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-c635a7ad05

FEDORA-2024-5ed72f1c81 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-5ed72f1c81 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-5ed72f1c81

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2024-267d66d22c has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-267d66d22c \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-267d66d22c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2024-c635a7ad05 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-c635a7ad05`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-c635a7ad05

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2024-267d66d22c (rust-circular-buffer-0.1.7-3.fc39 and rust-drop-tracker-0.1.3-2.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2024-c635a7ad05 (rust-circular-buffer-0.1.7-3.fc38 and rust-drop-tracker-0.1.3-2.fc38) has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2024-5ed72f1c81 (rust-circular-buffer-0.1.7-3.fc40 and rust-drop-tracker-0.1.3-2.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.