Bug 2266726 - Review Request: rust-drop-tracker - To check when a variable gets dropped
Summary: Review Request: rust-drop-tracker - To check when a variable gets dropped
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/drop-tracker
Whiteboard:
Depends On:
Blocks: 2266733
TreeView+ depends on / blocked
 
Reported: 2024-02-28 20:51 UTC by Ben Beasley
Modified: 2024-04-19 21:30 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-02-28 22:11:15 UTC
Type: Bug
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 7084048 to 7084397 (803 bytes, patch)
2024-02-28 21:01 UTC, Fedora Review Service
no flags Details | Diff

Description Ben Beasley 2024-02-28 20:51:00 UTC
Spec URL: https://music.fedorapeople.org/rust-drop-tracker.spec
SRPM URL: https://music.fedorapeople.org/rust-drop-tracker-0.1.3-1.fc41.src.rpm

Description:

Crate to check when a variable gets dropped. Useful for testing wrappers
and containers that use unsafe memory management.

Fedora Account System Username: music

This is a test dependency for rust-circular-buffer, which is needed for bpftop.

Comment 1 Fedora Review Service 2024-02-28 20:54:22 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7084048
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2266726-rust-drop-tracker/fedora-rawhide-x86_64/07084048-rust-drop-tracker/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Ben Beasley 2024-02-28 20:58:47 UTC
That’s not the source RPM I meant to use.

Spec URL: https://music.fedorapeople.org/rust-drop-tracker.spec
SRPM URL: https://music.fedorapeople.org/rust-drop-tracker-0.1.3-1.fc39.src.rpm

Comment 3 Fedora Review Service 2024-02-28 21:01:45 UTC
Created attachment 2019341 [details]
The .spec file difference from Copr build 7084048 to 7084397

Comment 4 Fedora Review Service 2024-02-28 21:01:48 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7084397
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2266726-rust-drop-tracker/fedora-rawhide-x86_64/07084397-rust-drop-tracker/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Fabio Valentini 2024-02-28 21:06:32 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 6 Ben Beasley 2024-02-28 21:54:58 UTC
Thanks!

https://release-monitoring.org/project/371601/

Comment 7 Ben Beasley 2024-02-28 21:57:26 UTC
Waiting for Pagure to come back:

$ fedpkg request-repo rust-drop-tracker 2266726
Could not execute request_repo: HTTPSConnectionPool(host='pagure.io', port=443): Read timed out. (read timeout=60)

Comment 8 Fedora Update System 2024-02-28 22:08:20 UTC
FEDORA-2024-3f7314bec1 (rust-drop-tracker-0.1.3-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-3f7314bec1

Comment 9 Fedora Update System 2024-02-28 22:11:15 UTC
FEDORA-2024-3f7314bec1 (rust-drop-tracker-0.1.3-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Ben Beasley 2024-02-29 13:24:15 UTC
I’ve only built this for F41 right now, but it looks like it’s possible to build it for all Fedoras and for EPEL9.

Comment 11 Fedora Update System 2024-04-05 18:34:05 UTC
FEDORA-2024-5ed72f1c81 (rust-circular-buffer-0.1.7-3.fc40 and rust-drop-tracker-0.1.3-2.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-5ed72f1c81

Comment 12 Fedora Update System 2024-04-05 18:34:38 UTC
FEDORA-2024-267d66d22c (rust-circular-buffer-0.1.7-3.fc39 and rust-drop-tracker-0.1.3-2.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-267d66d22c

Comment 13 Fedora Update System 2024-04-05 19:13:57 UTC
FEDORA-2024-c635a7ad05 (rust-circular-buffer-0.1.7-3.fc38 and rust-drop-tracker-0.1.3-2.fc38) has been submitted as an update to Fedora 38.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-c635a7ad05

Comment 14 Fedora Update System 2024-04-06 01:04:26 UTC
FEDORA-2024-5ed72f1c81 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-5ed72f1c81 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-5ed72f1c81

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2024-04-06 01:10:52 UTC
FEDORA-2024-267d66d22c has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-267d66d22c \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-267d66d22c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 16 Fedora Update System 2024-04-06 01:59:25 UTC
FEDORA-2024-c635a7ad05 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-c635a7ad05`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-c635a7ad05

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 17 Fedora Update System 2024-04-14 01:36:04 UTC
FEDORA-2024-267d66d22c (rust-circular-buffer-0.1.7-3.fc39 and rust-drop-tracker-0.1.3-2.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 18 Fedora Update System 2024-04-14 03:08:11 UTC
FEDORA-2024-c635a7ad05 (rust-circular-buffer-0.1.7-3.fc38 and rust-drop-tracker-0.1.3-2.fc38) has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 19 Fedora Update System 2024-04-19 21:30:30 UTC
FEDORA-2024-5ed72f1c81 (rust-circular-buffer-0.1.7-3.fc40 and rust-drop-tracker-0.1.3-2.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.