Bug 2267091
| Summary: | Review Request: rust-escape8259 - RFC8259-compliant string escaping and un-escaping | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Arthur Bols <arthur> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://crates.io/crates/escape8259 | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-03-14 20:29:21 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2258358 | ||
|
Description
Arthur Bols
2024-02-29 17:00:58 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/7092232 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2267091-rust-escape8259/fedora-rawhide-x86_64/07092232-rust-escape8259/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - licenses of statically linked dependencies are correctly taken into account - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) === Please add a comment about what the patch is / does. The patch looks reasonable, maybe something like # * exclude some files that are only useful for upstream development Looks like this should also be acceptable as an upstream patch if you submitted it. Thanks for the review! I've upstreamed the patch [0] and improved the comment. [0]: https://github.com/ericseppanen/escape8259/pull/1 The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-escape8259 FEDORA-2024-3f097e90bb (rust-escape8259-0.5.2-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-3f097e90bb FEDORA-2024-3f097e90bb (rust-escape8259-0.5.2-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-be842e1335 (rust-escape8259-0.5.2-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-be842e1335 FEDORA-2024-b68fa91f6b (rust-escape8259-0.5.2-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-b68fa91f6b FEDORA-2024-9c8a40bef3 (rust-escape8259-0.5.2-1.fc38) has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-9c8a40bef3 FEDORA-EPEL-2024-e5ef45fc2b (rust-escape8259-0.5.2-1.el9) has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-e5ef45fc2b FEDORA-2024-be842e1335 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-be842e1335 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-be842e1335 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-b68fa91f6b has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-b68fa91f6b \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-b68fa91f6b See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2024-e5ef45fc2b has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-e5ef45fc2b See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-9c8a40bef3 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-9c8a40bef3 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-9c8a40bef3 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-be842e1335 (rust-escape8259-0.5.2-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-EPEL-2024-e5ef45fc2b (rust-escape8259-0.5.2-1.el9) has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-b68fa91f6b (rust-escape8259-0.5.2-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-9c8a40bef3 (rust-escape8259-0.5.2-1.fc38) has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. |