Bug 2267091 - Review Request: rust-escape8259 - RFC8259-compliant string escaping and un-escaping
Summary: Review Request: rust-escape8259 - RFC8259-compliant string escaping and un-es...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/escape8259
Whiteboard:
Depends On:
Blocks: 2258358
TreeView+ depends on / blocked
 
Reported: 2024-02-29 17:00 UTC by Arthur Bols
Modified: 2024-03-24 01:35 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-03-14 20:29:21 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Arthur Bols 2024-02-29 17:00:58 UTC
Spec URL: https://principis.fedorapeople.org/rust-escape8259.spec
SRPM URL: https://principis.fedorapeople.org/rust-escape8259-0.5.2-1.fc39.src.rpm
Description: RFC8259-compliant string escaping and un-escaping
Fedora Account System Username: principis

Comment 1 Fedora Review Service 2024-02-29 17:04:19 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7092232
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2267091-rust-escape8259/fedora-rawhide-x86_64/07092232-rust-escape8259/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2024-03-14 16:33:47 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- licenses of statically linked dependencies are correctly taken into account
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

Please add a comment about what the patch is / does. The patch looks reasonable, maybe something like

# * exclude some files that are only useful for upstream development

Looks like this should also be acceptable as an upstream patch if you submitted it.

Comment 3 Arthur Bols 2024-03-14 19:24:02 UTC
Thanks for the review! I've upstreamed the patch [0] and improved the comment.

[0]: https://github.com/ericseppanen/escape8259/pull/1

Comment 4 Fedora Admin user for bugzilla script actions 2024-03-14 19:24:33 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-escape8259

Comment 5 Fedora Update System 2024-03-14 19:41:57 UTC
FEDORA-2024-3f097e90bb (rust-escape8259-0.5.2-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-3f097e90bb

Comment 6 Fedora Update System 2024-03-14 20:29:21 UTC
FEDORA-2024-3f097e90bb (rust-escape8259-0.5.2-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Fedora Update System 2024-03-15 16:59:59 UTC
FEDORA-2024-be842e1335 (rust-escape8259-0.5.2-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-be842e1335

Comment 8 Fedora Update System 2024-03-15 17:00:15 UTC
FEDORA-2024-b68fa91f6b (rust-escape8259-0.5.2-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-b68fa91f6b

Comment 9 Fedora Update System 2024-03-15 17:07:39 UTC
FEDORA-2024-9c8a40bef3 (rust-escape8259-0.5.2-1.fc38) has been submitted as an update to Fedora 38.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-9c8a40bef3

Comment 10 Fedora Update System 2024-03-15 17:08:14 UTC
FEDORA-EPEL-2024-e5ef45fc2b (rust-escape8259-0.5.2-1.el9) has been submitted as an update to Fedora EPEL 9.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-e5ef45fc2b

Comment 11 Fedora Update System 2024-03-16 01:06:27 UTC
FEDORA-2024-be842e1335 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-be842e1335 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-be842e1335

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2024-03-16 01:48:31 UTC
FEDORA-2024-b68fa91f6b has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-b68fa91f6b \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-b68fa91f6b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2024-03-16 01:58:54 UTC
FEDORA-EPEL-2024-e5ef45fc2b has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-e5ef45fc2b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2024-03-16 02:06:22 UTC
FEDORA-2024-9c8a40bef3 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-9c8a40bef3 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-9c8a40bef3

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2024-03-23 00:38:14 UTC
FEDORA-2024-be842e1335 (rust-escape8259-0.5.2-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 16 Fedora Update System 2024-03-24 00:37:25 UTC
FEDORA-EPEL-2024-e5ef45fc2b (rust-escape8259-0.5.2-1.el9) has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 17 Fedora Update System 2024-03-24 01:06:22 UTC
FEDORA-2024-b68fa91f6b (rust-escape8259-0.5.2-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 18 Fedora Update System 2024-03-24 01:35:30 UTC
FEDORA-2024-9c8a40bef3 (rust-escape8259-0.5.2-1.fc38) has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.